sunxi: Ippo_q8h: Enable OTG VBUS detection using AXP223
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 3 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 3 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [U-Boot] [PATCH 0/3] sunxi: Ippo_q8h: Enable OTG VBUS detection using AXP223
Hi,
Quoted 9 lines · Chen-Yu Tsai
Hi Hans,
This series fixes otg support on the A23 q8h tablets. It adds support for the AXP's (AXP221/223 for now) VBUS detection function.
I've tested this with a USB wireless keyboard dongle, which works fine. More importantly, I'm using this and your mainline kernel musb work plus a few A23 dts patches to get musb working on my q8h tablet in host mode. I have an ethernet dongle plugged in, which works reasonably well.
Thanks for working on this, I've merged this into u-boot-sunxi/next and I plan to send a pull-req for this to get it into v2015.4-rc# soon, as this fixes a regression which I (deliberately) introduced.
It would be cool if you do similar patches for the mainline kernel, for the mainline kernel I would really like to see the status bit exported as part of the gpio-chip which we still need to add to the axp2xx code for the axp2xx gpio pins, this way the existing kernel musb code can just use it.
I also believe that Ian was right when he said that we should probably also make these bits special gpio-s in u-boot rather then using custom API-s for them. But this is something which we can fix later, for now this fixes the regression and as such is good enough.
Quoted 2 lines
Note that U-Boot never calls
musb_shutdown()to do proper cleanup, like disabling VBUS, so the current state carries on into Linux.
Hmm true, I guess that is not necessarily a problem, but something which we do need to keep in mind.
Regards,
Hans