support/download: be more aggressive on missing hashes (branch yem/dl-hash-2)

Quoted 23 lines · Yann E. MORIN

Thomas, All,

On 2015-04-01 22:08 +0200, Thomas Petazzoni spake thusly:

Quoted 2 lines · Yann E. MORIN

Quoted 1 line

This series makes hashes mandatory when a .hash file exists.

[--SNIP--]

Quoted 17 lines

I applied this and was going to push it, but I believe there's still a problem.

If I change strace.hash so that there is no hash matching the tarball name of strace, then I get two times the error:

$ make strace-extract
ERROR: No hash found for strace-4.10.tar.xz
ERROR: No hash found for strace-4.10.tar.xz
package/pkg-generic.mk:73: recipe for target '/home/thomas/projets/buildroot/output/build/strace-4.10/.stamp_downloaded' failed

I haven't looked too deeply, but I believe it's because check-hash returns 3, so dl-wrapper exits with error code 1, which means that the pkg-download.mk logic concludes that the download from the upstream location has failed, so it retries with sources.buildroot.net, and the same thing happens.

Quoted 7 lines

Quoted 1 line

Is this expected?

That's at least the result I expect, yes.

I know this might look weird, indeed. However, I did not find a simple
way to avoid this.

I think this weird behaviour is acceptable (for now). It is indeed hard to
avoid, and anyway this is not something that a normal user would ever encounter.

In a perfect world the entire download logic would move to a script (which
admittedly would get a sh*tload of arguments). Then it would be much simpler to exit properly.

Regards,
Arnout

[snip]