Skip to content

mtd: nand: mxs: Calculate ECC strength dynamically

Heiko Schocher u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest3 of 4 patches 0 repliesNew

3 of 4 patches are in this archive. The cover letter announces 4.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
3/4mtd: nand: mxs: Add comment for calculating ECC strength+0 -01 reply
3/4mtd: nand: mxs: Add comment for calculating ECC strength+0 -01 reply
3/4mtd: nand: mxs: Add comment for calculating ECC strength+0 -00 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHeiko Schocher
SeriesA-b
3/4
3/4
3/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [U-Boot] [PATCH v2 0/4] mtd: nand: mxs: Calculate ECC strength dynamically

Hello J?rg,

Am 13.04.2015 22:17, schrieb J?rg Krause:

Quoted 19 lines

This series of patches are based on the patch of Peng Fan:
https://patchwork.ozlabs.org/patch/422756/

Patch 1 is the originally patch from Peng Fan, Patch 2 and 3 add minor changes to 1 and patch 4 adds the ECC strength calculation to tools/mxsboot to be aligned with the changes made in patch 1 to 3.

Instead of hard-coding every possible oob size / ECC strength combination calculate the ECC strength dynamically to be aligned with the Linux Kernel MTD NAND driver. Also adds the calculation to tools/mxsboot to be aligned with the U-Boot MTD NAND driver.

Obviously, we have some code redundancy here in mxs_nand.c and mxsboot.c.

J?rg Krause (3):
mtd: nand: mxs: Replace magic number for bits per ECC level with macro
mtd: nand: mxs: Add comment for calculating ECC strength
tools: mxsboot: Calculate ECC strength dynamically

Quoted 6 lines

Peng Fan (1):
mtd:mxs:nand calculate ecc strength dynamically

  drivers/mtd/nand/mxs_nand.c | 36 +++++++++++++++---------------------
  tools/mxsboot.c             | 39 ++++++++++++++++++++++++---------------
  2 files changed, 39 insertions(+), 36 deletions(-)

Tried this patches on the aristainetos2 board. UBI on the nand works nice with this patches, so:

Acked-by Heiko Schocher <[email protected]>

This patchset replaces my patch:

Patchwork [U-Boot] mxs_nand: Fix ECC strength for NAND flash with OOB size of 256
http://patchwork.ozlabs.org/patch/460462/

bye,
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Read the cover letter in its thread