Skip to content

matchbox: huge cleanups (branch yem/matchbox)

Arnout Vandecappelle buildroot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest30 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/30package/matchbox: make matchbox-lib a real package+0 -00 replies
2/30package/matchbox: make matchbox-wm a real package+0 -00 replies
2/30package/matchbox: make matchbox-wm a real package+0 -00 replies
3/30package/matchbox-wm: drop useless commented options+0 -00 replies
4/30package/matchbox: make matchbox-panel a real package+0 -00 replies
4/30package/matchbox: make matchbox-panel a real package+0 -00 replies
4/30package/matchbox: make matchbox-panel a real package+0 -00 replies
5/30package/matchbox: make matchbox-desktop a real package+0 -01 reply
6/30package/matchbox: make matchbox-common a real package+0 -00 replies
7/30package/matchbox: make matchbox-fakekey a real package+0 -00 replies
8/30package/matchbox: make matchbox-keyboard a real package+0 -00 replies
9/30package/matchbox: make match-startup-monitor a real package+0 -01 reply
10/30package/matchbox: remove superfluous conditional includes+0 -01 reply
11/30package/matchbox: point to new home+0 -00 replies
12/30package/matchbox: get rid of intermediate non-package matchbox+0 -01 reply
13/30package/matchbox: fix option prompts+0 -01 reply
14/30package/matchbox-common: fix dependencies+0 -00 replies
15/30package/matchbox-common: break dependency chain for display+0 -01 reply
16/30package/matchbox-fakekey: add missing dependency+0 -00 replies
17/30package/matchbox-startup-monitor: add misisng dependency+0 -00 replies
18/30package/matchbox: finally add prompts to all sub-packages+0 -01 reply
19/30package/matchbox: enable support for the Xsession manager+0 -01 reply
20/30package/matchbox: cleanup handling of support for compositing+0 -00 replies
21/30package/matchbox: make it a menu+0 -00 replies
22/30package/matchbox: forcibly disable support for compositing+0 -01 reply
23/30package/matchbox: drop useless dependencies+0 -00 replies
23/30package/matchbox: drop useless dependencies+0 -02 replies
24/30package/matchbox-keyboard: enforce disabling support for cairo+0 -00 replies
25/30package/matchbox-common: explicitly disable PDA folders when not selected+0 -00 replies
27/30package/matchbox: xlib-libXcursor is an optional dependency+0 -01 reply
28/30package/matchbox-panel: add option to use ACPI for the battery applet+0 -01 reply
29/30package/matchbox-panel: add support for dnotify+0 -01 reply
30/30package/matchbox-panel: fix WiFi monitoring+0 -00 replies

Reviews trailers per patch

28 of 33 patches have a Reviewed-by or Acked-by.

PatchArnout Vandecappelle (Essensium/Mind)
1/30R-b
2/30R-b
2/30R-b
3/30A-b
4/30R-b
4/30R-b
4/30R-b
5/30R-b
6/30R-b
7/30R-b
8/30R-b
9/30
10/30R-b
11/30A-b
12/30R-b
13/30
14/30R-b
15/30
16/30A-b
17/30A-b
18/30A-b
19/30R-b
20/30R-b
21/30R-b
22/30R-b
23/30R-b
23/30R-b
24/30R-b
25/30R-b
27/30R-b
28/30
29/30
30/30R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Buildroot] [PATCH 0/30] matchbox: huge cleanups (branch yem/matchbox)
Quoted 3 lines · Yann E. MORIN

Hello All!

This series is an attempt at cleaning up the matchbox packages.

Hi Yann,

Kudos for this!

Quoted 12 lines

Currently, the matchbox pckages are in a dire situation, where some package do not even have a corresponding BR2_PACKAGE_FOO option, but are nonetheless build dependencies ones of others.

Also, some support code has been bit-rotting and is not even buildable today, ike support for compositing, which simply FTBFS.

Finally, some dependencies are incorrect. For example, there are build dependencies not expressed in the Kconfig (not even counting the missing Kconfig entries for packages), or are entirely wrong.

Quoted 8 lines

So, this series aims at fixing all of this. And add a little bit of extra features we're currently missing. Not everything that is possible with matchbox has been handled, though, like support for NLS.

The series is split into multiple parts;

- patches 1-9 make all packages real packages, i.e. with proper Kconfig options. No functionality change.

One overall remark to this part of the series: I'd move them directly under
package/ which is supposed to be the standard way of doing things now, so get rid of the matchbox subdirectory. That's also the way it works with Kodi BTW.

Regards,
Arnout

Quoted 20 lines

- patches 10-13 do a little eye-candy cleanups. No functionality change.

- patches 14-17 fixes dependencies. No functionality change done on purpose, except because of added proper dependency tracking.

- patch 18 stands out alone, a bit of eye-candy to add prompts for previously prompt-less packages. No functionality change.

- patches 19-30 are not really sorted. They ar ea mix of fixes, eye-candy and the few new features.

This has been build-tested only, with about every combinations possible excercised, for ARM. No run-time testing has been done, though.

Enjoy! ;-)

Regards,
Yann E. MORIN.

[snip]

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F