Skip to content

sfc: Get/Set MAC address and ndo_[set/get]_vf_* entrypoint functions

Shradha Shah netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest16 patches 1 replyIn review
  2. v20 of 16 patches 1 replySuperseded
  3. v116 patches 1 replySuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16sfc: Add permissions to MCDI commandsdrivers/net/ethernet/sfc/mcdi_pcol.h+294 -00 replies
2/16sfc: change definition of MC_CMD_VADAPTOR_ALLOCdrivers/net/ethernet/sfc/mcdi_pcol.h+14 -10 replies
3/16sfc: MC_CMD_SET_MAC can only be called by the link control Functiondrivers/net/ethernet/sfc/ef10.c+8 -10 replies
4/16sfc: Store vf_index in nic_data for Ef10.drivers/net/ethernet/sfc/ef10.c drivers/net/ethernet/sfc/nic.h+52 -170 replies
5/16sfc: save old MAC address in case sriov_mac_address_changed failsdrivers/net/ethernet/sfc/ef10_sriov.h drivers/net/ethernet/sfc/efx.c drivers/net/ethernet/sfc/net_driver.h +2 more+21 -70 replies
6/16sfc: Store the efx_nic struct of the current VF in the VF data structdrivers/net/ethernet/sfc/ef10.c drivers/net/ethernet/sfc/ef10_sriov.c drivers/net/ethernet/sfc/ef10_sriov.h+37 -00 replies
7/16sfc: protect filter table against use-after-freedrivers/net/ethernet/sfc/ef10.c drivers/net/ethernet/sfc/efx.c drivers/net/ethernet/sfc/efx.h +2 more+55 -120 replies
8/16sfc: Enable a VF to get its own MAC addressdrivers/net/ethernet/sfc/ef10.c drivers/net/ethernet/sfc/net_driver.h+34 -20 replies
9/16sfc: Initialise MCDI buffers to 0 on declaration.drivers/net/ethernet/sfc/ef10.c drivers/net/ethernet/sfc/mcdi.c drivers/net/ethernet/sfc/mcdi.h +1 more+27 -230 replies
10/16sfc: add ndo_set_vf_mac() function for EF10drivers/net/ethernet/sfc/ef10_sriov.c drivers/net/ethernet/sfc/ef10_sriov.h drivers/net/ethernet/sfc/efx.c +1 more+96 -70 replies
11/16sfc: Add ndo_get_vf_config() function for EF10drivers/net/ethernet/sfc/ef10_sriov.c drivers/net/ethernet/sfc/ef10_sriov.h+26 -50 replies
12/16sfc: Change entity reset on MC reboot to a new datapath-only reset.drivers/net/ethernet/sfc/ef10.c drivers/net/ethernet/sfc/efx.c drivers/net/ethernet/sfc/enum.h +1 more+21 -50 replies
13/16sfc: add ndo_set_vf_vlan() function for EF10drivers/net/ethernet/sfc/ef10_sriov.c drivers/net/ethernet/sfc/ef10_sriov.h+157 -120 replies
14/16sfc: add ndo_set_vf_link_state() function for EF10drivers/net/ethernet/sfc/ef10.c drivers/net/ethernet/sfc/ef10_sriov.c drivers/net/ethernet/sfc/ef10_sriov.h +5 more+93 -00 replies
15/16sfc: Implement dummy disable of VF spoof check for EF10drivers/net/ethernet/sfc/ef10_sriov.c drivers/net/ethernet/sfc/ef10_sriov.h+8 -50 replies
16/16sfc: set the MAC address using MC_CMD_VADAPTOR_SET_MACdrivers/net/ethernet/sfc/ef10.c drivers/net/ethernet/sfc/ef10_sriov.h drivers/net/ethernet/sfc/efx.c +4 more+120 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH net-next v3 00/16] sfc: Get/Set MAC address and ndo_[set/get]_vf_* entrypoint functions

This is the second instalment of patches towards supporting EF10 SRIOV.

This patch series implements the ndo_get_vf_config, ndo_set_vf_mac, ndo_set_vf_vlan and ndo_set_vf_spoofcheck function callbacks for EF10.

This patch series also introduces privileges for the MCDI commands based on which functions are allowed to call them, i.e. Link control or primary function.

The patch series has been tested with and without CONFIG_SFC_SRIOV.

The ndo function callbacks are tested using ip link.

Daniel Pieczko (1):
sfc: Enable a VF to get its own MAC address

Edward Cree (2):
sfc: protect filter table against use-after-free
sfc: add ndo_set_vf_link_state() function for EF10

Jon Cooper (2):
sfc: Initialise MCDI buffers to 0 on declaration.
sfc: Change entity reset on MC reboot to a new datapath-only reset.

Shradha Shah (11):
sfc: Add permissions to MCDI commands
sfc: change definition of MC_CMD_VADAPTOR_ALLOC
sfc: MC_CMD_SET_MAC can only be called by the link control Function
sfc: Store vf_index in nic_data for Ef10.
sfc: save old MAC address in case sriov_mac_address_changed fails
sfc: Store the efx_nic struct of the current VF in the VF data struct
sfc: add ndo_set_vf_mac() function for EF10
sfc: Add ndo_get_vf_config() function for EF10
sfc: add ndo_set_vf_vlan() function for EF10
sfc: Implement dummy disable of VF spoof check for EF10
sfc: set the MAC address using MC_CMD_VADAPTOR_SET_MAC

 drivers/net/ethernet/sfc/ef10.c        | 279 ++++++++++++++++++++----
 drivers/net/ethernet/sfc/ef10_sriov.c  | 320 ++++++++++++++++++++++++++-
 drivers/net/ethernet/sfc/ef10_sriov.h  |  36 ++--
 drivers/net/ethernet/sfc/efx.c         |  65 ++++--
 drivers/net/ethernet/sfc/efx.h         |   5 +
 drivers/net/ethernet/sfc/enum.h        |   2 +
 drivers/net/ethernet/sfc/ethtool.c     |   2 +-
 drivers/net/ethernet/sfc/mcdi.c        |  12 +-
 drivers/net/ethernet/sfc/mcdi.h        |   8 +-
 drivers/net/ethernet/sfc/mcdi_pcol.h   | 381 ++++++++++++++++++++++++++++++++-
 drivers/net/ethernet/sfc/mcdi_port.c   |   1 +
 drivers/net/ethernet/sfc/net_driver.h  |  11 +-
 drivers/net/ethernet/sfc/nic.h         |   1 +
 drivers/net/ethernet/sfc/ptp.c         |   6 +-
 drivers/net/ethernet/sfc/siena.c       |   2 +-
 drivers/net/ethernet/sfc/siena_sriov.c |   6 +-
 drivers/net/ethernet/sfc/siena_sriov.h |   2 +-
 drivers/net/ethernet/sfc/sriov.c       |  12 ++
 drivers/net/ethernet/sfc/sriov.h       |   2 +
 19 files changed, 1055 insertions(+), 98 deletions(-)