sfc: add MCDI tracing
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest3 patches 1 replyIn review
- v34 patches 1 replySuperseded
- v24 patches 3 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 1 reply | Superseded |
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | sfc: add tracing of MCDI commandsdrivers/ drivers/ drivers/ +1 more | +102 | 0 replies | |
| 2/3 | sfc: add sysfs entry to control MCDI tracingdrivers/ drivers/ drivers/ +1 more | +48 | 0 replies | |
| 3/3 | sfc: add module parameter to enable MCDI logging on new functionsdrivers/ | +9 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.
Cover letter [PATCH net-next v4 0/3] sfc: add MCDI tracing
This patchset adds support for logging MCDI (Management-Controller-to-
Driver Interface) interactions between the sfc driver and a bound device, to aid in debugging.
Solarflare has a tool to decode the resulting traces and will look to
open-source this if there is any external interest, but the protocol is already detailed in drivers/net/ethernet/sfc/mcdi_pcol.h.
The logging buffer we allocate per MCDI context is a work area for
constructing each individual message before logging it with netif_info.
The reason the buffer is long-lived is simply to avoid the overhead of
allocating and freeing it every MCDI call, since MCDIs are already known to be serialised for other reasons.
--
v4: remove patch #4, which has already been applied via sshah
v3: add some explanations to cover letter and patch #4
v2: avoid long lines in cover letter; fix multiline comment style
Edward Cree (3):
sfc: add tracing of MCDI commands
sfc: add sysfs entry to control MCDI tracing
sfc: add module parameter to enable MCDI logging on new functions
drivers/net/ethernet/sfc/Kconfig | 9 ++++ drivers/net/ethernet/sfc/ef10.c | 3 ++ drivers/net/ethernet/sfc/efx.c | 49 ++++++++++++++++--- drivers/net/ethernet/sfc/mcdi.c | 100 +++++++++++++++++++++++++++++++++++++-- drivers/net/ethernet/sfc/mcdi.h | 6 +++ 5 files changed, 156 insertions(+), 11 deletions(-)