RFC nfsd/sunrpc: prepare nfsd to add workqueue mode support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 RFC Latest7 patches 1 replyIn review
- v3 RFC7 patches 7 repliesSuperseded
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | nfsd/sunrpc: add a new svc_serv_ops struct and move sv_shutdown into itfs/ fs/ fs/ +2 more | +33 | 0 replies | |
| 2/7 | nfsd/sunrpc: move sv_function into sv_opsfs/ include/ net/ | +8 | 0 replies | |
| 3/7 | nfsd/sunrpc: move sv_module parm into sv_opsfs/ include/ net/ | +11 | 0 replies | |
| 4/7 | nfsd/sunrpc: turn enqueueing a svc_xprt into a svc_serv operationfs/ fs/ fs/ +3 more | +18 | 0 replies | |
| 5/7 | nfsd/sunrpc: abstract out svc_set_num_threads to sv_opsfs/ include/ | +8 | 0 replies | |
| 6/7 | nfsd/sunrpc: move pool_mode definitions into svc.hinclude/ net/ | +32 | 0 replies | |
| 7/7 | nfsd/sunrpc: factor svc_rqst allocation and freeing from sv_nrthreads refcountinginclude/ net/ | +39 | 0 replies |
Reviews trailers per patch
All 7 patches have a Reviewed-by or Acked-by.
| Patch | Jeff Layton | Shirley Ma |
|---|---|---|
| 1/7 | A-b | T-b |
| 2/7 | A-b | T-b |
| 3/7 | A-b | T-b |
| 4/7 | A-b | T-b |
| 5/7 | A-b | T-b |
| 6/7 | A-b | T-b |
| 7/7 | A-b | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH V4 0/7] nfsd/sunrpc: prepare nfsd to add workqueue mode support
This patchset was originally written by Jeff Layton from adding support for a workqueue-based nfsd. I am helping on stability test and performance analysis. There are some workloads benefit from global threading mode, some workloads benefit from workqueue mode. I am still investigating on how to make workqueue mode better to bid global threading mode. I have split the original patchset into two parts: one is preparing nfsd to add workqueue support, one is adding workqueue mode. This is the first patchset, which doesn't impact nfsd threading mode performance based upon my test results. These changes make nfsd threading code more clean and easy to add workqueue mode in nfsd/sunrpc later.
sunrpc: add a new svc_serv_ops struct and move sv_shutdown into it
sunrpc: move sv_function into sv_ops
sunrpc: move sv_module parm into sv_ops
sunrpc: turn enqueueing a svc_xprt into a svc_serv operation
sunrpc: abstract out svc_set_num_threads to sv_ops
sunrpc: move pool_mode definitions into svc.h
sunrpc: factor svc_rqst allocation and freeing from sv_nrthreads refcounting
fs/lockd/svc.c | 7 ++- fs/nfs/callback.c | 6 ++- fs/nfsd/nfssvc.c | 17 ++++-- include/linux/sunrpc/svc.h | 68 +++++++++++++++++------- include/linux/sunrpc/svc_xprt.h | 1 + net/sunrpc/svc.c | 113 +++++++++++++++++++--------------------- net/sunrpc/svc_xprt.c | 10 ++-- 7 files changed, 135 insertions(+), 87 deletions(-)