Skip to content

sunxi: musb: Fix "usb reset" handling

Hans de Goede u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/2] sunxi: musb: Fix "usb reset" handling

Hi,

Quoted 7 lines · Paul Kocialkowski

Le dimanche 14 juin 2015 ? 12:40 +0200, Hans de Goede a ?crit :

Quoted 5 lines

Hi Ian, Paul,

Here is a patch to fix the problems where most usb devices will no longer work after a "usb reset ", when connected to the otg controller in host mode + a related cleanup patch.

Quoted 8 lines

This works fine for an USB storage device and an USB2 keyboard but does not work with an USB1 keyboard, with error:

sunxi# usb reset
resetting USB...
USB0: scanning bus 0 for devices... USB device descriptor short read
(expected 8, got 0)
No USB Device found

Hmm, did you test my sunxi-wip branch perhaps? This bug does exist there, but it is the result of me refactoring things so that the musb code can use the device-model when build in host mode, which will allow enabling both the otg port in host mode and regular usb hosts in a single build, which is esp. useful for boards which have the otg hooked up in host-only mode (e.g. connected to an usb-a receptacle, or usb <-> sata bridge).

I've just retested current u-boot/master with just this patch and the problem you are describing does not happen then.

Sorry about my sunxi-wip being broken atm I try to always keep it 100% functional, but well it is a wip tree after all.

Regards,

Hans