Skip to content

ocfs2: Deletion of some unnecessary checks

SF Markus Elfring acpica-devel alsa-devel ath10k ath9k-devel backports batman ceph-devel cluster-devel cocci dm-devel dri-devel ecryptfs intel-gfx kernel-janitors kvm linux-acpi linux-arm-kernel linux-arm-msm linux-audit linux-bcache linux-block linux-bluetooth linux-btrfs linux-crypto linux-devicetree linux-ext4 linux-f2fs-devel linux-fbdev linux-fsdevel linux-gpio linux-hwmon linux-ia64 linux-ide linux-input linux-iommu linux-kbuild linux-media linux-mediatek linux-mm linux-mtd linux-nfs linux-nilfs linux-nvdimm linux-omap linux-parisc linux-pci linux-pm linux-ppp linux-pwm linux-raid linux-rdma linux-rockchip linux-s390 linux-samsung-soc linux-scsi linux-sctp linux-sh linux-spi linux-tegra linux-wireless linux-wpan linux-xfs linuxppc-dev lkml lustre-devel lvs-devel netdev netfilter-devel nouveau nvdimm ocfs2-devel platform-driver-x86 virtualization xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11ocfs2: Delete an unnecessary check before unregister_sysctl_table()fs/ocfs2/stackglue.c+1 -20 replies
2/11ocfs2: Delete unnecessary checks before the function call "iput"fs/ocfs2/alloc.c fs/ocfs2/ioctl.c fs/ocfs2/journal.c +4 more+11 -300 replies
3/11ocfs2: Less checks in ocfs2_rename() after error detectionfs/ocfs2/namei.c+7 -63 replies
4/11ocfs2: One check less in ocfs2_statfs()fs/ocfs2/super.c+8 -110 replies
5/11ocfs2: Less error log repetition in ocfs2_begin_truncate_log_recovery()fs/ocfs2/alloc.c+10 -110 replies
6/11ocfs2: Two checks less in ocfs2_local_alloc_slide_window()fs/ocfs2/localalloc.c+10 -150 replies
7/11ocfs2: Less function calls in ocfs2_shutdown_local_alloc() after error detectionfs/ocfs2/localalloc.c+12 -150 replies
8/11ocfs2: Less checks in ocfs2_load_local_alloc()fs/ocfs2/localalloc.c+10 -90 replies
9/11ocfs2: One function call less in ocfs2_trylock_journal() after error detectionfs/ocfs2/journal.c+5 -80 replies
10/11ocfs2: Less function calls in ocfs2_replay_journal() after error detectionfs/ocfs2/journal.c+10 -130 replies
11/11ocfs2: One function call less in ocfs2_journal_shutdown() from input checksfs/ocfs2/journal.c+6 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/11] ocfs2: Deletion of some unnecessary checks

From: Markus Elfring <[email protected]>

Further update suggestions were taken into account after two patches were applied from static source code analysis.

Markus Elfring (11):
Delete an unnecessary check before unregister_sysctl_table() Delete unnecessary checks before the function call "iput" Less checks in ocfs2_rename() after error detection
One check less in ocfs2_statfs()
Less error log repetition in ocfs2_begin_truncate_log_recovery() Two checks less in ocfs2_local_alloc_slide_window()
Less function calls in ocfs2_shutdown_local_alloc() after error detection Less checks in ocfs2_load_local_alloc()
One function call less in ocfs2_trylock_journal() after error detection Less function calls in ocfs2_replay_journal() after error detection One function call less in ocfs2_journal_shutdown() from input checks

 fs/ocfs2/alloc.c      | 24 +++++++--------
 fs/ocfs2/ioctl.c      |  4 +--
 fs/ocfs2/journal.c    | 62 +++++++++++++++----------------------
 fs/ocfs2/localalloc.c | 84 +++++++++++++++++++++------------------------------
 fs/ocfs2/namei.c      | 17 +++++------
 fs/ocfs2/slot_map.c   |  3 +-
 fs/ocfs2/stackglue.c  |  3 +-
 fs/ocfs2/super.c      | 22 ++++++--------
 8 files changed, 90 insertions(+), 129 deletions(-)
Signature · 1 line
2.4.5