ARM: OMAP2+: hwmod: RTC: Add lock and unlock hooks
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 3 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 3 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] ARM: OMAP2+: hwmod: RTC: Add lock and unlock hooks
Quoted 17 lines · Paul Walmsley
Quoted 9 lines · Tero Kristo
Quoted 8 lines · Lokesh Vutla
Hi,
Quoted 6 lines · Lokesh Vutla
Some IP blocks like RTC, needs an additional unlocking mechanism for writing to its registers. This patch adds optional lock and unlock function pointers to the IP block's hwmod data which gets executed before and after writing into IP sysconfig register.
And also hook lock and unlock functions to AMx3xx, DRA7 RTC hwmod data, so that sysconfig registers are updated properly.Quoted 5 lines
Quoted 4 lines
ping on this series.
Thanks and regards,
Lokesh
Quoted 6 lines
[...]
Quoted 2 lines
It is also racy, as there is no locking in place to avoid concurrent access to the lock/unlock registers across hwmod+driver.
I don't see the race. Where is it?
See drivers/rtc/rtc-omap.c, am3352_rtc_unlock and am3352_rtc_lock.
That code is accessing the exact same registers.
-Tero