Add DT support for netxbig LEDs

Jacek Anaszewski linux-arm-kernel linux-leds 2 versions Jul 25, 2015 New

Get series with b4

b4 am [email protected]

Versions newest first · linked by author and title

v2 Latest posting 2/2 Jul 25, 20150 of 3 patches 0 repliesNew
v2 posting 1/2 Jul 25, 20150 of 3 patches 0 repliesSuperseded

Patches in v2 posting 2/2 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

Patch	Gregory CLEMENT
Series	A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] Add DT support for netxbig LEDs

I confused two patch sets. Everything I wrote in the reply below was related to leds-ns2 [1] patch set.
When it is related to leds-netxbig driver - there was already version 3 posted [2], but it is not the final one, we are waiting for the update.

Quoted 21 lines · Jacek Anaszewski

Hi Gregory,
Quoted 5 lines · Gregory CLEMENT
Hi Simon, Bryan, Richard,
Quoted 2 lines · Simon Guinot
Hello,
Quoted 7 lines
Quoted 3 lines
This patch series adds DT support for the LEDs found on the Kirkwood-based
LaCie boards 2Big and 5Big Network v2.
I saw that some led related patch on kirkwood based board have been merged.
What is the status of this series?
LED subsystem part has been merged to linux-next, since DTS files are not required for the compilation to succeed. We've been waiting for ARM/Marvell Kirkwood maintainer opinion to decide on how to proceed regarding patch 2/4.

Quoted 57 lines

Quoted 1 line
I still have the patch 2 and 3 in my inbox waiting for being applied.
Patch 3 affects only drivers/leds/leds-ns2.c, you were probably thinking of patch 1 which modifies the out of LED tree file include/linux/platform_data/leds-kirkwood-ns2.h.
IMO it would be best if the whole series went through the LED tree.
Quoted 47 lines
Thanks,
Gregory
Quoted 40 lines
Changes since v1:
- Check timer mode value retrieved from DT.
- In netxbig_leds_get_of_pdata, don't use unsigned long variables to get timer delay values from DT with function of_property_read_u32_index. Instead, use a temporary u32 variable. This allows to silence a
static
checker warning.
- Make timer property optional in the binding documentation. It is now aligned with the driver code.
Simon
Simon Guinot (3):
leds: netxbig: add device tree binding
ARM: Kirkwood: add LED DT entries for netxbig boards
ARM: mvebu: remove static LED setup for netxbig boards
  .../devicetree/bindings/gpio/netxbig-gpio-ext.txt  |  22 ++
  .../devicetree/bindings/leds/leds-netxbig.txt      |  92 ++++++++
  arch/arm/boot/dts/kirkwood-net5big.dts             |  60 +++++
  arch/arm/boot/dts/kirkwood-netxbig.dtsi            |  80 +++++++
  arch/arm/mach-mvebu/Kconfig                        |   7 -
  arch/arm/mach-mvebu/Makefile                       |   1 -
  arch/arm/mach-mvebu/board.h                        |  21 --
  arch/arm/mach-mvebu/kirkwood.c                     |   4 -
  arch/arm/mach-mvebu/netxbig.c                      | 191
----------------
  drivers/leds/leds-netxbig.c                        | 250
+++++++++++++++++++--
  include/dt-bindings/leds/leds-netxbig.h            |  18 ++
  11 files changed, 501 insertions(+), 245 deletions(-)
create mode 100644
Documentation/devicetree/bindings/gpio/netxbig-gpio-ext.txt
create mode 100644
Documentation/devicetree/bindings/leds/leds-netxbig.txt
delete mode 100644 arch/arm/mach-mvebu/board.h delete mode 100644 arch/arm/mach-mvebu/netxbig.c create mode 100644 include/dt-bindings/leds/leds-netxbig.h

[1]
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-July/353807.html
[2]
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/351486.html

Signature · 2 lines

Best Regards,
Jacek Anaszewski

Read the cover letter in its thread