Skip to content

Fix operation on Odroid devices

Przemyslaw Marczak u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 of 4 patches 0 repliesNew

1 of 4 patches is in this archive. The cover letter announces 4.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
4/4exynos: fix and cleanup do_sdhci_init()+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/4] Fix operation on Odroid devices

Hello Tobias,

Quoted 18 lines · Tobias Jakobi

Hello,

currently operation on Exynos4412-based Odroid devices is broken.

The bootloader stops with this message:
Card did not respond to voltage select!
*** Warning - MMC init failed, using default environment

This series fixes error handling in the s5p sdhci driver and the cause of the issue, which is an inverted card detection check.

Thanks goes to Marek Vasut and Sjoerd Simons who helped me on IRC to get this triaged.

With best wishes,
Tobias

Quoted 9 lines

Tobias Jakobi (4):
exynos: Properly initialize host_caps in s5p_sdhci_core_init()
exynos: Fix passing of errors in exynos_mmc_init()
exynos: be more verbose in process_nodes()
exynos: fix and cleanup do_sdhci_init()

  drivers/mmc/s5p_sdhci.c | 39 +++++++++++++++++++++++----------------
  1 file changed, 23 insertions(+), 16 deletions(-)

NAK for the series, since the real problem is in device tree parsing, not in s5p_sdhci.c. I will send patches in a moment.

Best regards,

Signature · 4 lines
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com