Skip to content

mmc: Wait for card_busy before starting sdio requests

Jaehoon Chung linux-arm-kernel linux-mmc 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] mmc: Wait for card_busy before starting sdio requests

Hi,

Quoted 57 lines · Doug Anderson

Hi,

Quoted 35 lines · Hans de Goede

Hi,

Quoted 5 lines · Ulf Hansson
Quoted 3 lines · Hans de Goede

Hi Ulf,

Quoted 7 lines
Quoted 4 lines

Here is a non RFC version of my patch-set to wait for card_busy before starting sdio requests. It is the same as the RFC version of the set, but this time it has been tested no hardware which actually needs this and I can confirm now that this fixes wifi on that hardware.

Great! Thanks, applied for next!

Great, thanks, I guess it is too late for this to go as a fix into 4.3-rcX (no worries if it is) ?

Quoted 9 lines
Quoted 6 lines

This patch-set should also allow removing this dw_mmc specific fix:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/mmc/host/dw_mmc.c?id=0bdbd0e88cf6b603a2196418672715b0890fb040

As this patch-set fixes this problem in a generic manner.

Care to send a patch to remove the above hack/fix?

I do not have any hardware to test this.

I've added Doug the original author of that patch to the Cc.

Quoted 7 lines

Dough, can you test if with the patch set from this mail thread (merged into mmc/next) this patch:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/mmc/host/dw_mmc.c?id=0bdbd0e88cf6b603a2196418672715b0890fb040

Is still necessary ? Since this patch-set fixes the same issue in the mmc core I believe that this commit can be reverted now.

I'll try to find some time in the next few days to test, but I'm not terribly hopeful we can just revert the patch because:

1. Only one of the two callers of dw_mci_wait_while_busy() is handled by your patch. mci_send_cmd() is used internally in dw_mmc to throw something in the CMD register without going through the normal MMC path. This is used exclusively to update the clock registers in dw_mmc. I'm pretty sure this needs the wait, too. It's always seemed weird / awkward to me that you need to use the CMD register to update clock settings in dw_mmc, but c'est la vie.

Quoted 7 lines

2. If I remember correctly, we ran into other instances where non-SDIO cards needed the busy check. It wasn't terribly common, but I think I ran into this when stress testing, but only on a few cards. The patch referenced here only seems to check for SDIO commands. As I understand it, to be correct, it should check for all data commands (other than stop or voltage change commands). The Designware Databook makes no reference to only needing the wait for SDIO commands.

I agreed absolutely for Doug's comment.

Best Regards,
Jaehoon Chung

Quoted 18 lines

...of course, it's always possible that some of the things I saw above will no longer happen with all the other fixes we've done in the meantime (turning on voltages at the right time, adding the right delays, etc).

Note that I've hardly looked at sdhci at all, but on SDHCI is this handled by the "SDHCI_DATA_INHIBIT" bits?

-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html