Skip to content

Fix fdt 'reg' parsing and unbreak Odroid U3

Przemyslaw Marczak u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 3 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/3] Fix fdt 'reg' parsing and unbreak Odroid U3

Hello Jaehoon,

Quoted 9 lines · Jaehoon Chung

Hi, Przemyslaw.

Quoted 6 lines · Przemyslaw Marczak

Booting of Odroid U3 with SD card, ends with error:

MMC: EXYNOS DWMMC: 0
Card did not respond to voltage select!
*** Warning - MMC init failed, using default environment

Quoted 7 lines
Quoted 1 line

Generally this was broken, because of wrong addresses assigned to GPIOs.

Great! I will check this patch-set..But it seems to look good to me. :)

Best Regards,
Jaehoon Chung

At present, the patchset was tested on U3/X2 and XU3.

Quoted 20 lines
Quoted 20 lines

The source of the problem was in rework of lib/fdtdec.c, after which function fdtdec_get_addr() doesn't work as previous and function dev_get_addr() doesn't works as expected.

The code after rework in lib/fdtdec.c assume, that #size-cells property, should be always greater or equal to 1. This was wrong, because it can be 0.

In case of debugging the issue I found, that mmc clock was computed wrong, for Exynos4, because of function get_mmc_clk(), which always return -1 for this SoC.

Tested on: Odroid U3 and Odroid XU3.

Przemyslaw Marczak (3):
fix: fdtdec: allow parse 'reg' property with zero value in

     '#size-cells'

fix: s5p_gpio: call: dev_get_addr() instead of fdtdec_get_addr()
fix: mach-exynos: clock: restore calling dead exynos4_get_mmc_clk()

Quoted 7 lines
Quoted 5 lines
  arch/arm/mach-exynos/clock.c | 10 ++++------
  drivers/gpio/s5p_gpio.c      | 18 +++++++++++-------
  lib/fdtdec.c                 |  2 +-
  3 files changed, 16 insertions(+), 14 deletions(-)

Best regards,

Signature · 4 lines
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com