ARM: s3cxxxx: Use PWM lookup table
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | ARM: s3c24xx: h1940: Use PWM lookup table | +0 | 0 replies | |
| 2/6 | ARM: s3c24xx: rx1950: Use PWM lookup table | +0 | 1 reply | |
| 2/6 | ARM: s3c24xx: rx1950: Use PWM lookup table | +0 | 0 replies | |
| 3/6 | ARM: s3c64xx: smdk6410: Use PWM lookup table | +0 | 0 replies | |
| 4/6 | ARM: s3c64xx: crag6410: Use PWM lookup table | +0 | 0 replies | |
| 5/6 | ARM: s3c64xx: hmt: Use PWM lookup table | +0 | 1 reply | |
| 5/6 | ARM: s3c64xx: hmt: Use PWM lookup table | +0 | 0 replies | |
| 6/6 | ARM: s3c64xx: smartq: Use PWM lookup table | +0 | 0 replies |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Krzysztof Kozlowski |
|---|---|
| 1/6 | R-b |
| 2/6 | R-b |
| 2/6 | R-b |
| 3/6 | R-b |
| 4/6 | R-b |
| 5/6 | R-b |
| 5/6 | R-b |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/6] ARM: s3cxxxx: Use PWM lookup table
W dniu 06.10.2015 o 17:43, Thierry Reding pisze:
Quoted 20 lines · Krzysztof Kozlowski
Quoted 10 lines · Thierry Reding
Quoted 9 lines
Back when the PWM framework was introduced the concept of PWM lookup tables was added to allow board code to register a table of PWM devices and their association with consumers. The goal is to allow drivers to use a unified method to request PWM devices. At the same time, since no boards were exposing these tables, fallback code was kept in drivers to allow old code to remain functional. In order to get rid of the legacy fallback code, legacy users need to be updated to register PWM lookup tables.
Quoted 8 lines
Quoted 4 lines
This series converts all s3c24xx and s3c64xx boards that hook up a pwm- backlight device to use the new PWM lookup tables. All patches have been compile-tested, but I don't have access to any of these boards, so I couldn't verify that they really work.
Unfortunately I can't verify them neither. I don't have these boards. In that case I would prefer approach "if it ain't broken, don't touch it"... unless someone tests the patches of course.
Quoted 7 lines
Backlight on these boards is likely to be currently broken anyway. In fact this series is part of an effort to restore backlight support for these legacy boards (I sent out a similar series for PXA boards).
We're going to need to have this series merged so that we can remove the legacy code that's being a lot of trouble maintaining. If this series ends up breaking anything, I'd be happy to help fix things up.
So you suspect that it is already broken? Fair enough, I'll look at the patches.
In the same time these are really old SoCs for mobile standard. I wonder if anyone uses them... :)
Tomasz,
Do you have 6410 board? I remember you were quite involved in it.
Best regards,
Krzysztof