Switch to generic syscon regmap based drivers

Markus Reichl linux-arm-kernel linux-devicetree linux-samsung-soc 4 versions Oct 20, 2015 – Oct 21, 2015 New

Get series with b4

b4 am [email protected]

Versions newest first · linked by author and title

v2 Latest posting 3/3 Oct 21, 20150 of 6 patches 0 repliesNew
v2 posting 2/3 Oct 20, 20150 of 6 patches 0 repliesSuperseded
v2 posting 1/3 Oct 20, 20150 of 6 patches 0 repliesSuperseded

Earlier versions · 1

Version	Posted	Patches	Replies	Status
v1	Oct 20, 2015	0 of 7 patches	0 replies	Superseded

Patches in v2 posting 3/3 No applies recorded yet

None of the 6 patches the cover letter announces are in this archive.

Reviews trailers per patch

Patch	Markus Reichl	Anand Moon
Series	T-b	T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] Switch to generic syscon regmap based drivers

Am 21.10.2015 um 12:16 schrieb Javier Martinez Canillas:

Quoted 64 lines

Hello Alim,
On 10/21/2015 08:09 AM, Alim Akhtar wrote:
[snip]
Quoted 21 lines
Quoted 21 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Hi Alim,
I have installed your patch set above with git am on top of 4.3.0-rc6-00108-gce1fad2 torvalds/linux of today with make exynos_defconfig on Odroid U3.
Quoted 10 lines
Quoted 2 lines
which exynos soc Odroid U3 uses?
OK, I can see its uses exynos4412 and exynos4412-odroidu3.dts does include exynos4.dtsi,
so these should have worked.
Quoted 4 lines
Quoted 3 lines
"halt -p" worked (power 0.0W).
"reboot" got stuck at 0.5W.
reboot stuck mean system does not reboot any more?
It freezes when going for reboot. Have to power off/on to boot again.
Quoted 7 lines
Quoted 4 lines
Btw I use an mmc, not an sd-card. No other HW connected, just LAN-cable. Bootloader is u-boot v2015.10.
o
Have checked on 4.3.0-rc6-00006-gd03c139e7e77, still works on peach boards.
Sorry I don't have Odroid U3 with me, may be Javier or Krzysztof might help here to check whats wrong. To me its looks more of a board specific issue for now.
Krzysztof has an Odroid XU3 lite and I have an Odroid XU4, both uses an Exynos5422 so we can't check what's wrong with Odroid U3 (Exynos4412).
Having said that I think I know what is the issue here. Markus said that he is using an eMMC instead of an uSD (which is what I used and my guess is that Krzysztof did too).
Now, there is a subtle difference between the old PMU restart handler and the syscon-reboot one, and that is the restart handler priorities:
notifier priority
------------------------------------
pmu_restart_notify          128
mmc_pwrseq_emmc_reset_nb    129
syscon_restart_handle       192
So, without Alim's patches, first the eMMC reset handler will be called and then the PMU restart handler but after his series, the syscon reset handler has a higher priority so the eMMC reset will never be called.
But the problem is that the eMMC card has to be properly reset on system restart to allow the SoC iROM to be able to read the bootloader from the eMMC since the iROM doesn't have restart logic and the card shouldn't be left in an unknown state.
So the problem here is not that the system is not being reset (that I think that works) but that on reboot, the system is not able to boot again since the ROM is not able to read the second stage bootloader.

Quoted 6 lines

Markus,
Can you please test following patch [0] on top of Alim's series? If that works then it should either be part of Alim's series or the patches will have to wait until that patch lands into mainline. I don't have an eMMC to test it in XU4 but I'm pretty confident that it will solve the issue.

Hi Javier,

your patch fixes the issue, reboot works now on U3.

Tested-by Markus Reichl <[email protected]>

Thanks,
--
Markus

Quoted 3 lines

Best regards,

Read the cover letter in its thread