Skip to content

Inode security label invalidation

Stephen Smalley cluster-devel ocfs2-devel selinux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest5 of 7 patches 3 repliesIn review

5 of 7 patches are in this archive. The cover letter announces 7.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7selinux: Remove unused variable in selinux_inode_init_security+0 -00 replies
2/7selinux: Add accessor functions for inode->i_security+0 -01 reply
3/7selinux: Get rid of file_path_has_perm+0 -01 reply
3/7selinux: Get rid of file_path_has_perm+0 -00 replies
3/7selinux: Get rid of file_path_has_perm+0 -01 reply

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchStephen Smalley
1/7A-b
2/7
3/7
3/7
3/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [Ocfs2-devel] [PATCH v3 0/7] Inode security label invalidation
Quoted 11 lines · Andreas Gruenbacher

Here is another version of the patch queue to make gfs2 and similar file systems work with SELinux. As suggested by Stephen Smalley [*], the relevant uses of inode->security are wrapped in function calls that try to revalidate invalid labels.

   [*] http://marc.info/?l=linux-kernel&m=144416710207686&w=2

The patches are looking good from my point of view; is there anything else that needs addressing?

Does SELinux have test suites that these patches could be tested agains?

git clone https://github.com/SELinuxProject/selinux-testsuite
sudo yum install perl-Test perl-Test-Harness selinux-policy-devel gcc libselinux-devel net-tools netlabel_tools iptables
cd selinux-testsuite
sudo make test

Quoted 21 lines

Thanks,
Andreas

Andreas Gruenbacher (7):
selinux: Remove unused variable in selinux_inode_init_security
selinux: Add accessor functions for inode->i_security
selinux: Get rid of file_path_has_perm
selinux: Push dentry down from {dentry,path,file}_has_perm
security: Add hook to invalidate inode security labels
selinux: Revalidate invalid inode security labels
gfs2: Invalide security labels of inodes when they go invalid

  fs/gfs2/glops.c                   |   2 +
  include/linux/lsm_hooks.h         |   6 ++
  include/linux/security.h          |   5 +
  security/security.c               |   8 ++
  security/selinux/hooks.c          | 213 ++++++++++++++++++++++----------------
  security/selinux/include/objsec.h |   6 ++
  6 files changed, 152 insertions(+), 88 deletions(-)