core: ditch LD_LIBRARY_PATH (branch yem/no-ld-library-path)
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 of 6 patches 0 repliesNew
5 of 6 patches are in this archive. The cover letter announces 6.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | package/axfsutils: fix Makefile | +0 | 0 replies | |
| 2/6 | package/mysql: unconditionally define host variables | +0 | 0 replies | |
| 3/6 | package/perl-file-util: remove host variant | +0 | 0 replies | |
| 4/6 | package/libcurl: carefully override LD_LIBRARY_PATH | +0 | 0 replies | |
| 5/6 | core: check host executables have appropriate RPATH | +0 | 1 reply |
Reviews trailers per patch
4 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Arnout Vandecappelle (Essensium/Mind) |
|---|---|
| 1/6 | A-b T-b |
| 2/6 | A-b |
| 3/6 | A-b |
| 4/6 | R-b |
| 5/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Buildroot] [PATCH 0/6] core: ditch LD_LIBRARY_PATH (branch yem/no-ld-library-path)
Hi Peter,
Quoted 22 lines · Yann E. MORIN
Hello All!
This series is an attempt to ditch
LD_LIBRARY_PATHfor host binaries.Using
LD_LIBRARY_PATHis causing build issues on certain distributions, like Fedore 23, see:https://bugs.busybox.net/show_bug.cgi?id=8456 http://lists.busybox.net/pipermail/buildroot/2015-October/142898.htmlBasically, on Fedora 23, ls (from coreutils) is now linked to libcap, which is also linked to libattr. However, outr own libcap is not linked to libattr, and ls is too. However, because of our
LD_LIBRARY_PATH, the host ls is using our libcap, and thus fails to run.This series:
- ?xes a few host packages, add RPATH to packages where it is missing
- fixes the host-mysql definition, allow it to be built always
- removes host-perl-file-util, it is not used anywhere and is broken
- cleanups libcurl aboutLD_LIBRARY_PATH
- adds a script to check that host binaries have appropriate RPATH
- finally removesLD_LIBRARY_PATH
Quoted 6 lines
Even though this is a relatively intrusive change, it in my opinion should go in master now, otherwise, we'd get a full release cycle broken on Fedora, which would really be a shame... :-/
Regards,
Yann E. MORIN.
Please commit this series ASAP so it can still get some autobuilder exposure.
Except for patch 5/6 which could use some work, but that's anyway not essential.
Regards,
Arnout
Quoted 39 lines
The following changes since commit
2bc7c2e009ac08ae80cbf3ce736ade16a6cfcb26:zxing-cpp: needs dynamic library (2015-11-13 16:39:29 +0100)
are available in the git repository at:
git://git.busybox.net/~ymorin/git/buildrootyem/no-ld-library-pathfor you to fetch changes up to
0a14a9ff7f39c78d2a39f8ccde40a9f7a6d020b2:core/pkg-infrastructures: remove
LD_LIBRARY_PATHfrom the environment (2015-11-13 19:51:07 +0100)----------------------------------------------------------------
Ben Boeckel (1):
core/pkg-infrastructures: removeLD_LIBRARY_PATHfrom the environmentYann E. MORIN (5):
package/axfsutils: fixMakefilepackage/mysql: unconditionally define host variables package/perl-file-util: remove host variant package/libcurl: carefully overrideLD_LIBRARY_PATH
core: check host executables have appropriate RPATHpackage/Makefile.in | 2 - package/axfsutils/0001-fix-cflags.patch | 19 +++++++++ package/axfsutils/0002-use-ldflags.patch | 20 +++++++++ package/axfsutils/axfsutils.mk | 2 +- package/libcurl/libcurl.mk | 2 +- package/mysql/mysql.mk | 39 +++++++++--------- package/perl-file-util/perl-file-util.mk | 1 - package/pkg-generic.mk | 8 ++++ support/scripts/check-host-rpath | 71 ++++++++++++++++++++++++++++++++ 9 files changed, 140 insertions(+), 24 deletions(-) create mode 100644 package/axfsutils/0001-fix-cflags.patch create mode 100644 package/axfsutils/0002-use-ldflags.patch create mode 100755 support/scripts/check-host-rpath
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF