Skip to content

mtd: bcm63xxpart: Add NAND partitioning support

Simon Arlott linux-mips linux-mtd lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest11 patches 5 repliesIn review
  2. v13 patches 6 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11MIPS: bcm963xx: Add Broadcom BCM963xx board nvram data structureMAINTAINERS include/linux/bcm963xx_nvram.h+113 -00 replies
2/11MIPS: bcm63xx: nvram: Use nvram structure definition from header filearch/mips/bcm63xx/nvram.c+3 -320 replies
3/11MIPS: bcm963xx: Move Broadcom BCM963xx image tag data structureMAINTAINERS arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h drivers/mtd/bcm63xxpart.c +1 more+100 -970 replies
4/11MIPS: bcm963xx: Move extended flash address to bcm_tag header filedrivers/mtd/bcm63xxpart.c include/linux/bcm963xx_tag.h+7 -40 replies
5/11MIPS: bcm963xx: Update bcm_tag field image_sequenceinclude/linux/bcm963xx_tag.h+5 -60 replies
6/11mtd: bcm63xxpart: Remove dependency on mach-bcm63xxdrivers/mtd/Kconfig drivers/mtd/bcm63xxpart.c+58 -161 reply
7/11MIPS: bcm63xx: nvram: Remove unused bcm63xx_nvram_get_psi_size() functionarch/mips/bcm63xx/nvram.c arch/mips/include/asm/mach-bcm63xx/bcm63xx_nvram.h+0 -132 replies
8/11mtd: bcm63xxpart: Extract read of image tag to separate functiondrivers/mtd/bcm63xxpart.c+40 -220 replies
9/11mtd: bcm63xxpart: Null terminate and validate conversion of flash stringsdrivers/mtd/bcm63xxpart.c+34 -40 replies
10/11mtd: bcm63xxpart: Move NOR flash layout to a separate functiondrivers/mtd/bcm63xxpart.c+32 -220 replies
11/11mtd: bcm63xxpart: Add NAND partitioning supportdrivers/mtd/bcm63xxpart.c+190 -61 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH linux-next v4 00/11] mtd: bcm63xxpart: Add NAND partitioning support

The BCM963xx NAND flash boards have a different handling of the partition layout from the NOR flash boards. For NAND there are offsets for the partitions in nvram. Both types of boards use the same CFE bootloader, nvram format and image tag in their rootfs partitions.

This patch series:

1-4:  Creates separate header files for bcm963xx_nvram and bcm_tag structures
5:    Updates the bcm_tag field image_sequence
6:    Removes the dependency on mach-bcm63xx from the bcm63xxpart parser
7:    Removes unused mach-bcm63xx nvram function

8-10: Cleanup and move NOR flash layout to a separate function
11: Add NAND flash layout support

Patches 1-2 tested on BCM63XX with a BCM963168 (NAND) board. Patches 3-11 compile tested on BCM63XX.
Patches 6-11 tested on BMIPS with a BCM963168 (NAND) board.
---
v4: Move struct bcm_tag to include/linux/.

Modify bcm63xx parser to read nvram from NOR flash and handle the NAND flash layout in the same parser.

v3: Fix includes/type names, add comments explaining the nvram struct.

Use COMPILE_TEST.

Ensure that strings read from flash are null terminated and validate bcm_tag integer values (this also moves reporting of rootfs sequence numbers to later on).

v2: Use external struct bcm963xx_nvram definition for bcm963268part.

Removed support for the nand partition number field, it's not a standard Broadcom field (was added by MitraStar Technology Corp.).

Signature · 1 line
Simon Arlott