Skip to content

usb: dwc2: add SPLIT transaction support

Stephen Warren u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6usb: dwc2: avoid out of bounds access+0 -02 replies
2/6usb: dwc2: Handle NAK during CONTROL DATA and STATUS stage+0 -01 reply
3/6usb: dwc2: determine TT hub address and port for split transactions+0 -015 replies
4/6usb: dwc2: add helper function for setting SPLIT HC registers+0 -00 replies
5/6usb: dwc2: add support for SPLIT transactions+0 -02 replies
6/6usb: dwc2: remove no longer used wait_for_chhltd()+0 -00 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchStephen WarrenMarek VasutHans de Goede
SeriesT-b
1/6A-b
2/6
3/6R-b R-b T-b R-b T-b
4/6A-b
5/6A-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/6] usb: dwc2: add SPLIT transaction support
Quoted 10 lines · Stefan Br?ns

First two patches are preparatory work. 3rd and 4th introduce helper functions. Patch 5 contains the core changes. Patch 6 is cleanup.

The patch has been tested on RPi 1 B with several full speed and low speed devices. All devices enumerated successfully, with good output from "usb info". High speed devices, e.g. the SMSC9514 ethernet and mass storage devices still work.

Neither CONFIG_DM_USB nor LS/FS devices directly connected to the root hub/hc have been tested, although both should be handled by the patches.

The series,

It's not perfect with the USB keyboards that I have (there are lots of rapid extra keyboard repeats), but it basically does work and so I think warrants the Tested-by. The extra repeats might be due to the strange hacks I put into dwc2.c:_submit_int_msg() to try and handle the NAKing of HID requests until the polling period has expired.