Skip to content

RFC all: use 'menuconfig' to group sub-options (branch yem/menuconfig)

Arnout Vandecappelle buildroot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest0 of 84 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 84 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchArnout Vandecappelle (Essensium/Mind)
SeriesA-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Buildroot] [PATCH 0/84 RFC] all: use 'menuconfig' to group sub-options (branch yem/menuconfig)
Quoted 32 lines · Yann E. MORIN

Arnout, All,

On 2016-01-02 02:47 +0100, Arnout Vandecappelle spake thusly:

Quoted 29 lines · Yann E. MORIN
Quoted 27 lines

On 2015-12-31 01:23 +0100, Arnout Vandecappelle spake thusly:

Quoted 15 lines · Yann E. MORIN
Quoted 14 lines

Hello All!

This RFC series is a proposal to cleanup the layout of the menuconfig UI. Although it looks to be pretty long (84 patches), it really is only three different changes :

- patches 1-6: re-order comments to fix indentation of sub-options; this can probably be applied without too much discussion, as it is really only a cleanup;

- patches 7-35: changes use of 'config'+'menu' into a 'menuconfig' (the Kconfig keywords) to automatically arrange the sub-options into sub-menus;

Quoted 8 lines
Quoted 4 lines

- patches 36-84: document that packages with 5 or more options should use sub-menus (with 'menuconfig') to store their sub-options (patches 36-39); it then changes a lot of packages accordingly (patches 40-84).

I reviewed and tested patches 7-39, you can add my

Thank you for the review. I know by experience that reviewing long series can be tedious, so: thanks!

Quoted 7 lines
Quoted 1 line

You can now ack up to and including 58 (libiio).

Great! Thank you very much for having had another look! :-)

(I'll add your ACKs after fixing the little nits here and there you already commented on, like comments to drop...)

And finally, for patches 59-84:

Thanks for this series, Yann!

Regards,
Arnout

Quoted 21 lines
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines

to the ones where I didn't have comments. I didn't bother adding Acks everywhere because it's anyway not going to be picked up by Patchwork.

Yep, I sent the series as an RFC, just to "feel the temperature of the water".

For actual submission, perhaps squash a little here and there. Although in fact
they're not really squashable, except perhaps 41-84 but that would be a pretty big patch.

Well, and what about my commit count? ;-]

But yeah, I don't think we could squash it, at least during the review. I think it is easier to review a lot of little patches rather than a bit one even if the changes are simple.

Thanks!

Regards,
Yann E. MORIN.

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF