Skip to content

IB/srpt patches for Linux kernel v4.6

Bart Van Assche linux-rdma 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest21 patches 4 repliesIn review
  2. v321 patches 5 repliesSuperseded
  3. v222 patches 21 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v115 patches41 repliesSuperseded

Changes in v4 from the cover letter

- Removed node_acl_size member from the srpt_template structure.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21IB/srpt: Simplify srpt_handle_tsk_mgmt()drivers/infiniband/ulp/srpt/ib_srpt.c+1 -580 replies
2/21IB/srpt: Add parentheses around sizeof argumentdrivers/infiniband/ulp/srpt/ib_srpt.c+21 -210 replies
3/21IB/srpt: Remove struct srpt_node_acldrivers/infiniband/ulp/srpt/ib_srpt.c drivers/infiniband/ulp/srpt/ib_srpt.h+0 -90 replies
4/21IB/srpt: Inline srpt_sdev_name()drivers/infiniband/ulp/srpt/ib_srpt.c+2 -120 replies
5/21IB/srpt: Inline srpt_get_ch_state()drivers/infiniband/ulp/srpt/ib_srpt.c+12 -300 replies
6/21IB/srpt: Introduce target_reverse_dma_direction()drivers/infiniband/ulp/srpt/ib_srpt.c+2 -150 replies
7/21IB/srpt: Use scsilun_to_int()drivers/infiniband/ulp/srpt/ib_srpt.c+7 -850 replies
8/21IB/srpt: Simplify channel state managementdrivers/infiniband/ulp/srpt/ib_srpt.c+13 -310 replies
9/21IB/srpt: Simplify srpt_shutdown_session()drivers/infiniband/ulp/srpt/ib_srpt.c drivers/infiniband/ulp/srpt/ib_srpt.h+2 -150 replies
10/21IB/srpt: Fix srpt_close_session()drivers/infiniband/ulp/srpt/ib_srpt.c+16 -150 replies
11/21IB/srpt: Fix srpt_handle_cmd() error pathsdrivers/infiniband/ulp/srpt/ib_srpt.c+12 -120 replies
12/21IB/srpt: Fix how aborted commands are processeddrivers/infiniband/ulp/srpt/ib_srpt.c+16 -330 replies
13/21IB/srpt: Inline trivial CM callback functionsdrivers/infiniband/ulp/srpt/ib_srpt.c+10 -270 replies
14/21IB/srpt: Eliminate srpt_find_channel()drivers/infiniband/ulp/srpt/ib_srpt.c+29 -650 replies
15/21IB/srpt: Log private data associated with REJdrivers/infiniband/ulp/srpt/ib_srpt.c+11 -23 replies
16/21IB/srpt: Use a mutex to protect the channel listdrivers/infiniband/ulp/srpt/ib_srpt.c drivers/infiniband/ulp/srpt/ib_srpt.h+17 -290 replies
17/21IB/srpt: Detect session shutdown reliablydrivers/infiniband/ulp/srpt/ib_srpt.c drivers/infiniband/ulp/srpt/ib_srpt.h+150 -1500 replies
18/21IB/srpt: Fix srpt_write_pending()drivers/infiniband/ulp/srpt/ib_srpt.c+4 -290 replies
19/21IB/srpt: Log out all initiators if a port is disableddrivers/infiniband/ulp/srpt/ib_srpt.c+19 -40 replies
20/21IB/srpt: Introduce srpt_process_wait_list()drivers/infiniband/ulp/srpt/ib_srpt.c+24 -180 replies
21/21IB/srpt: Fix wait list processingdrivers/infiniband/ulp/srpt/ib_srpt.c+15 -90 replies

Reviews trailers per patch

All 21 patches have a Reviewed-by or Acked-by.

PatchAlex EstrinChristoph HellwigSagi Grimberg
1/21T-b R-b
2/21R-b R-b
3/21R-b R-b
4/21R-b R-b
5/21R-b R-b
6/21R-b R-b
7/21R-b R-b
8/21R-b R-b
9/21R-b R-b
10/21R-b R-b
11/21R-b R-b
12/21R-b R-b
13/21R-b R-b
14/21R-b
15/21R-b
16/21R-b
17/21R-b
18/21R-b R-b
19/21R-b R-b
20/21R-b R-b
21/21R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/21] IB/srpt patches for Linux kernel v4.6

Hi Doug,

This series of patches is what I came up with while testing the most
recent version of my SCSI target patch series (see also
http://thread.gmane.org/gmane.linux.scsi.target.devel/10905). This
includes fixes for ABORT handling and lockups during driver shutdown.
All review comments that have been posted so far have been addressed in this patch series.

Changes compared to v3 of this patch series:
- Removed node_acl_size member from the srpt_template structure.

Changes compared to v2 of this patch series:
- Moved patch "Simplify srpt_handle_tsk_mgmt()" to the front of this patch series and added a "Cc: stable" tag.
- Removed the UNKNOWN_TMR definition again from include/target/target_core_base.h.
- Switched to list_empty_careful() in patch "Use a mutex to protect the channel list" such that it is no longer needed to introduce RCU in this patch series.
- Dropped patch "Do not complain about initiator names without leading 0x" because it modifies the same code as a pending patch series from Nic.

Changes compared to v1 of this patch series:
- Rebased this patch series on top of kernel v4.5-rc1.
- As proposed by Alex Estrin, modified patch "Simplify srpt_handle_tsk_mgmt()" such that task management function code validity is now checked by the target core.
- Added a comment in patch "Simplify channel state management".
- Changed "return true" into "return 1" in patch "Simplify srpt_shutdown_session()" as suggested by Christoph.
- Fixed patch "Fix srpt_handle_cmd() error paths" based on the feedback provided by Sagi.
- Split patch "Eliminate srpt_find_channel()" in three patches.
- Left out patch "Fix a rare crash in srpt_close_session()". It is no longer needed because srpt_disconnect_ch() is now called with the sdev mutex held.
- Added several new patches.

The patches in this patch series are:
0001-IB-srpt-Simplify-srpt_handle_tsk_mgmt.patch 0002-IB-srpt-Add-parentheses-around-sizeof-argument.patch 0003-IB-srpt-Remove-struct-srpt_node_acl.patch 0004-IB-srpt-Inline-srpt_sdev_name.patch 0005-IB-srpt-Inline-srpt_get_ch_state.patch 0006-IB-srpt-Introduce-target_reverse_dma_direction.patch 0007-IB-srpt-Use-scsilun_to_int.patch 0008-IB-srpt-Simplify-channel-state-management.patch 0009-IB-srpt-Simplify-srpt_shutdown_session.patch 0010-IB-srpt-Fix-srpt_close_session.patch 0011-IB-srpt-Fix-srpt_handle_cmd-error-paths.patch 0012-IB-srpt-Fix-how-aborted-commands-are-processed.patch 0013-IB-srpt-Inline-trivial-CM-callback-functions.patch 0014-IB-srpt-Eliminate-srpt_find_channel.patch 0015-IB-srpt-Log-private-data-associated-with-REJ.patch 0016-IB-srpt-Use-a-mutex-to-protect-the-channel-list.patch 0017-IB-srpt-Detect-session-shutdown-reliably.patch 0018-IB-srpt-Fix-srpt_write_pending.patch 0019-IB-srpt-Log-out-all-initiators-if-a-port-is-disabled.patch 0020-IB-srpt-Introduce-srpt_process_wait_list.patch 0021-IB-srpt-Fix-wait-list-processing.patch
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html