Skip to content

NVMe: Surprise removal fixes

Sagi Grimberg linux-nvme 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 of 4 patches 0 repliesNew

3 of 4 patches are in this archive. The cover letter announces 4.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4NVMe: Fix io incapable return values+0 -00 replies
2/4NVMe: Sync stopped queues with block layer+0 -01 reply
4/4blk-mq: End unstarted requests on dying queue+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] NVMe: Surprise removal fixes

Hi Keith,

Quoted 3 lines

Earlier feedback suggested this functionality be in the block layer. I don't have the devices to test what happens with other drivers, and the desired sequence seems unique to NVMe.

Umm, it actually isn't. I think this is what all the block drivers want.

Quoted 7 lines

Maybe that's an indication
that the driver's flow could benefit from some redesign, or maybe it's an artifact from having the controller and storage being the same device.

In any case, I would like to isolate this fix to the NVMe driver in the interest of time, and flush out the block layer before the next merge window.

I'm fine with that. But we definitely want to avoid the queue_rq conditional in the long run...