package/freeswitch: new package
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v9 Latest0 of 28 patches 0 repliesNew
- v81 of 28 patches 0 repliesSuperseded
Patches in v9 No applies recorded yet
None of the 28 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v9 yet.
Cover letter [Buildroot] [PATCH/next v9 00/28] package/freeswitch: new package
Hi Bernd, Thomas, All,
Le 29/02/2016 22:33, Thomas Petazzoni a ?crit :
Quoted 21 lines
Bernd,
Quoted 11 lines · Bernd Kuhls
this patch series splits my previous patch into smaller chunks for easier review as requested by Luca and Thomas. I also removed all options from Config.in.
Instead of enabling or disabling modules in the upstream modules.conf I decided to delete that file in the first patch to provide a minimal build for easier review, please keep in mind that I never did a run-time test with this minimal version. A lot of modules, desired as a default set, are added with the second patch - all of them have no external dependencies. The rest of the patch series consists of modules having some form of dependency, added module by module for easier review.
Thanks for this patch series. Besides my build issue and minor comments on PATCH 01/28, it looks fine. I've looked at all other patches, and despite a really minor nit on PATCH 26/28, I think we'll be able to apply this once the PATCH 01/28 problems are fixed.
Quoted 4 lines
The fact that you did split the package addition in a minimal package and then trivial additions of optional dependencies really made the whole thing a lot easier to look at and review, so thanks for having done that!
+1
Also, I tried to force the build system to use apr and apr-util libraries provided by Buildroot packages, but It's not easy without deep modifications and breaking a lot of stuff :-(
Let's hope that the further release will have a better build system...
Best regards,
Romain
Quoted 3 lines
Thomas