OMAP/pinmux: remove misuse of IRQF_NO_SUSPEND flag
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 of 3 patches 0 repliesNew
2 of 3 patches are in this archive. The cover letter announces 3.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | pinctrl: single: Use a separate lockdep class | +0 | 0 replies | |
| 3/3 | ARM: OMAP2+: remove misuse of IRQF_NO_SUSPEND flagarch/ | +2 | 1 reply |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Grygorii Strashko |
|---|---|
| 1/3 | R-b |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] OMAP/pinmux: remove misuse of IRQF_NO_SUSPEND flag
Quoted 31 lines · Tony Lindgren
Quoted 14 lines · Sudeep Holla
Hi Linus,
Quoted 11 lines · Linus Walleij
Quoted 8 lines · Sudeep Holla
pinctrl: single: Use a separate lockdep class
pinctrl: single: remove misuse ofIRQF_NO_SUSPENDflag
ARM: OMAP2+: remove misuse ofIRQF_NO_SUSPENDflagarch/arm/mach-omap2/mux.c | 4 ++-- arch/arm/mach-omap2/pm34xx.c | 9 ++++----- arch/arm/mach-omap2/prm_common.c | 1 + drivers/pinctrl/pinctrl-single.c | 15 ++++++++++++---Quoted 7 lines
Quoted 3 lines
Are these patches orthogonal so I can merge the pinctrl patch independently of the OMAP patches if Tony ACKs this?
Thanks for the follow up.
IIUC they are dependent and remember Tony/Grygorii wanted them to be merged together(at-least for bisectibility)AFAIK this series needs to be kept together to keep things working.
Quoted 5 lines
Quoted 2 lines
If not: should it be merged by me or through ARM SoC/Tony?
I think so.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Anyways waiting for maintainer feedback, but the above is good to know.
Grygorii was still not sure if this works and he couldn't give it a test. He was traveling and may need more time to get back on this.
He said it does not work so clearly more work is needed.
Yeah. As I mentioned before patches 2/3 will not work.
I've tried to test suspend with diff I posted [1], but I did it only on dra7 and am43 where suspend i more simple than on omap3. Also, I worry that with such approach some irq can be missed (especially edge ones), because PRCM irqs will be re-enabled at very late resume stage (right before thaw).
Second option, I see, is to rework PRCM to be threaded IRQ, but in this case all children IRQs will need to be threaded/nested threaded
(including PCS, legacy OMAP mux, OMAP3 _prcm_int_handle_wakeup/_prcm_int_handle_io).
Are there any objection to convert PCS to threaded IRQ, for example? ;)
[1] https://patchwork.ozlabs.org/patch/578915/
Signature · 2 lines
regards, -grygorii