Align library locations in target and staging
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest5 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | toolchain-external: blackfin: install FDPIC libraries also to staging | +0 | 0 replies | |
| 2/5 | toolchain-external: remove unused calculation of ARCH_SUBDIR | +0 | 0 replies | |
| 3/5 | toolchain-external: extract installation of gdbserver to separate define | +0 | 1 reply | |
| 4/5 | toolchain-external: align library locations in target and staging dir | +0 | 0 replies | |
| 5/5 | toolchain-external: unify LIB_EXTERNAL_LIBS and USR_LIB_EXTERNAL_LIBS | +0 | 0 replies |
Reviews trailers per patch
4 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Romain Naour |
|---|---|
| 1/5 | R-b |
| 2/5 | R-b |
| 3/5 | |
| 4/5 | R-b |
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Buildroot] [PATCH 0/5] Align library locations in target and staging
Hello Arnout, ThomasDS, All,
Le 27/03/2016 22:39, Arnout Vandecappelle a ?crit :
Quoted 26 lines · Thomas De Schampheleire
Quoted 18 lines
From: Thomas De Schampheleire <[email protected]>
As discussed on the Buildroot developer days, Buildroot installs some libraries in a different location in target than in staging. This is specifically seen for libstdc++ and libatomic.
This patch series tackles that problem and performs related cleanup.
Thomas De Schampheleire (5):
toolchain-external: blackfin: install FDPIC libraries also to staging
toolchain-external: remove unused calculation ofARCH_SUBDIR
toolchain-external: extract installation of gdbserver to separate
define
toolchain-external: align library locations in target and staging dir
toolchain-external: unifyLIB_EXTERNAL_LIBSandUSR_LIB_EXTERNAL_LIBSQuoted 6 lines
package/glibc/glibc.mk | 2 +- toolchain/helpers.mk | 57 ++--------------- toolchain/toolchain-external/Config.in | 3 +- toolchain/toolchain-external/toolchain-external.mk | 71 ++++++++++------------ 4 files changed, 40 insertions(+), 93 deletions(-)
Quoted 4 lines
I've also done a review and a test of the entire series. There is a bit of
reworking suggested by Romain in patch 3/5, the removal of -follow that I suggest in patch 4/5, and I would like to re-instate the --sysroot check in patch 2/5, but that's it.
What do you think about moving the sysroot check to a helper function like I propose in this series ? (Which needs to be rebased after ThomasDS's series as well)
http://patchwork.ozlabs.org/patch/576578/
http://patchwork.ozlabs.org/patch/576580/
Thoughts ?
Best regards,
Romain
Quoted 6 lines
ThomasDS, will you respin or do we apply and make changes afterwards?
Regards,
Arnout