Skip to content

Fix several static checker warnings reported against the iSCSI kernel code

Bart Van Assche linux-scsi 1 version Applied

Status from this message: Applied to 4.7/scsi-queue.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 6 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/5libiscsi: Unexport iscsi_eh_target_reset()drivers/scsi/libiscsi.c+1 -21 reply
2/5libiscsi: Remove set-but-not-used variablesdrivers/scsi/libiscsi.c+2 -41 reply
3/5scsi_transport_iscsi: Remove set-but-not-used variablesdrivers/scsi/scsi_transport_iscsi.c+0 -31 reply
4/5scsi_transport_iscsi: Unexport iscsi_is_flashnode_conn_dev()drivers/scsi/scsi_transport_iscsi.c+1 -21 reply
5/5scsi_transport_iscsi: Declare local symbols staticdrivers/scsi/scsi_transport_iscsi.c+4 -41 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchMike ChristieJohannes Thumshirn
1/5R-b R-b
2/5R-b R-b
3/5R-b R-b
4/5R-b R-b
5/5R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] Fix several static checker warnings reported against the iSCSI kernel code

Hello James and Martin,

These five patches are what I came up with after analyzing the output of "make M=drivers/scsi W=1 C=2" for the iSCSI initiator kernel code. Please consider these patches for inclusion in kernel v4.7. The actual patches are:

0001-libiscsi-Unexport-iscsi_eh_target_reset.patch 0002-libiscsi-Remove-set-but-not-used-variables.patch 0003-scsi_transport_iscsi-Remove-set-but-not-used-variabl.patch 0004-scsi_transport_iscsi-Unexport-iscsi_is_flashnode_con.patch 0005-scsi_transport_iscsi-Declare-local-symbols-static.patch

Thanks,

Bart.