Skip to content

tools/env: pass arguments as parameters not global structure

Stefano Babic u-boot 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 of 5 patches 0 repliesNew

1 of 5 patches is in this archive. The cover letter announces 5.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5tools/env: make env_aes_cbc_crypt re-entrant+0 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [U-Boot] [PATCH 0/5] tools/env: pass arguments as parameters not global structure

Hi Andreas,

Quoted 10 lines · Andreas Fenkart

u-boot tools can be built as a library (ibubootenv.a). Passing arguments to the library using global structures is not a good interface.

Andreas Fenkart (5):
tools/env: make env_aes_cbc_crypt re-entrant
tools/env: remove 'extern' from function prototype in fw_env.h tools/env: fw_printenv pass value_only as argument tools/env: compute size of usable area only once tools/env: no global variable sharing between application and library

Quoted 5 lines
 tools/env/fw_env.c      | 95 ++++++++++++++++++++++++++-----------------------
 tools/env/fw_env.h      | 31 ++++++----------
 tools/env/fw_env_main.c | 28 +++++++++------
 3 files changed, 78 insertions(+), 76 deletions(-)

I can confirm that series fixes building an external program using the env tools as environment. Thanks for fixing it !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Read the cover letter in its thread