Skip to content

video: fbdev: imxfb: make it work again

Tomi Valkeinen linux-arm-kernel linux-fbdev 2 versions New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/20 of 3 patches 0 repliesNew
  2. v2 posting 1/20 of 3 patches 0 repliesSuperseded

Patches in v2 posting 2/2 No applies recorded yet

None of the 3 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] video: fbdev: imxfb: make it work again
Quoted 13 lines · Uwe Kleine-K?nig

Hello Tomi,

Quoted 9 lines · Tomi Valkeinen
Quoted 6 lines · Uwe Kleine-K?nig

this is v2 of the series which addresses the review comments I got vor (implicit) v1.

For patch 2 the question is still open if this is the right fix, but without this the display doesn't stay on. Patches 1 and 3 should be applicable independant of patch 2.

I picked patches 1 and 3, they look fine.

Quoted 7 lines

Thanks.

Quoted 1 line

I still think patch 2 is just broken, it doesn't make sense to me.

What do you think should happen during startup? Something should call the set_power callback to enable the device? Or should that only happen when something writes to /dev/fb0?

I think the panel should be enabled at startup, as with fbdev there's no specific enable call. So I don't have a problem with enabling the panel at startup, but just that the regulator enables/disables don't seem to match.

Quoted 7 lines
Quoted 4 lines

If the regulator is enabled in probe, then it's always on, and imxfb_lcd_set_power() should be removed as it never has any effect. But that doesn't sound correct, as presumably the imxfb_lcd_set_power() has worked at some point.

I think it worked back when unused regulators were not disabled during boot.

Is imxfb_lcd_set_power() ever called, or just not at startup? If it is called properly later, then perhaps you just need to kick it at startup time to enable it. Maybe imxfb_lcd_set_power(lcd, FB_BLANK_UNBLANK);

Did you try unloading the module (both when the LCD is enabled and when it's disabled), and seeing that the regulator gets disabled when you unload it?

Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160510/8144c3b2/attachment.sig>

Read the cover letter in its thread