Skip to content

a few sdhci/imx clean up and fix patches

Adrian Hunter linux-arm-kernel linux-mmc 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest6 of 15 patches 0 repliesNew

6 of 15 patches are in this archive. The cover letter announces 15.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15mmc: sdhci: using common mmc_regulator_set_vqmmc()+0 -00 replies
4/15mmc: sdhci-esdhc-imx: restore watermark level setting after resume+0 -00 replies
8/15mmc: sdhci: add standard hw auto retuning support+0 -00 replies
12/15mmc: sdhci-esdhc-imx: factor out hw related initialization into function+0 -00 replies
14/15mmc: sdhci-esdhci-imx: re-initialize hw state after resume+0 -00 replies
15/15mmc: sdhci-esdhc-imx: clear tuning bits during driver probe+0 -00 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchAdrian Hunter
1/15A-b
4/15A-b
8/15A-b
12/15A-b
14/15A-b
15/15A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH V2 00/15] a few sdhci/imx clean up and fix patches
Quoted 2 lines · Dong Aisheng

Patch 1~10 are mainly sdhci cleanup patches while patch 7,9,10 are fixes which seems needed for stable tree as well.

I have ack'ed all the sdhci-related patches. i.e. all but patch 7 the dt bindings change.

I am not sure what needs to be done for stable. I would suggest these patches are queued for 4.8, then Dong can send the relevant patches to the linux-stable mailing list separately after -rc1.

Quoted 57 lines

The main work is:
1) using more robust mmc_regulator_set_vqmmc
2) add auto retune support
3) improve sdhci-esdhc-imx stability
4) add state save and restore for low power mode

Change Log:
v1->v2:
* address all Adrian's comments
* below patches are dropped
mmc: sdhci: move sdhci_get_cd() forward to avoid declaration
mmc: core: fix a comment typo
mmc: sdhci: re-factor sdhci_start_signal_voltage()
mmc: core: mmc_regulator_set_vqmmc not return error if vqmmc/vmmc not
exist
mmc: sdhci: check SDHCI_QUIRK2_NO_1_8_V when do voltage switch
mmc: sdhci: rename quirk SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12
Above clean up is not needed so far according to Adrian.

mmc: sdhci: fix incorrect get data interrupt during no data transfer
This one is not needed anymore cause Adrian had another fix already in tree.
(commit 0e0a35d2d4058 mmc: sdhci: Track whether a reset is pending)

mmc: core: disable auto retune during card detection process
This one will sent out in another patch series to fix in CORE.

v1:
http://www.spinics.net/lists/linux-mmc/msg36316.html

Dong Aisheng (15):
mmc: sdhci: using common mmc_regulator_set_vqmmc()
mmc: sdhci-esdhc-imx: remove SDHCI_QUIRK_BROKEN_TIMEOUT_VAL
mmc: sdhci-esdhc-imx: add esdhc specific suspend resume callback
mmc: sdhci-esdhc-imx: restore watermark level setting after resume
mmc: sdhci-esdhci-imx: disable DLL delay line settings explicitly
mmc: sdhci-esdhc-imx: support setting tuning start point
doc: dt: fsl-imx-esdhc: add set tuning start point binding
mmc: sdhci: add standard hw auto retuning support
mmc: sdhci-esdhc-imx: enable hw auto retuning for STD_TUNING
mmc: sdhci-esdhc-imx: enable hw auto retuning for MAN_TUNING
mmc: sdhci-esdhc-imx: fix strobe DLL lock wrong clock issue
mmc: sdhci-esdhc-imx: factor out hw related initialization into
function
mmc: sdhci-esdhc-imx: move tuning static configuration into hwinit
function
mmc: sdhci-esdhci-imx: re-initialize hw state after resume
mmc: sdhci-esdhc-imx: clear tuning bits during driver probe

 .../devicetree/bindings/mmc/fsl-imx-esdhc.txt      |   2 +
 drivers/mmc/host/sdhci-esdhc-imx.c                 | 149 ++++++++++++++-------
 drivers/mmc/host/sdhci.c                           |  24 ++--
 drivers/mmc/host/sdhci.h                           |   3 +
 include/linux/platform_data/mmc-esdhc-imx.h        |   1 +
 5 files changed, 122 insertions(+), 57 deletions(-)