Skip to content

improve qconfig C++ code, take 2

Rolf Eike Beer linux-kbuild lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4kconfig: qconf: use preferred form of QString APIscripts/kconfig/qconf.cc+4 -41 reply
2/4kconfig: qconf: use QCommandLineParserscripts/kconfig/qconf.cc+17 -271 reply
3/4kconfig: qconf: remove overloaded constructorscripts/kconfig/qconf.h+1 -62 replies
4/4kconfig: qconf: use nullptr in C++11 codescripts/kconfig/qconf.cc scripts/kconfig/qconf.h+25 -250 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] improve qconfig C++ code, take 2

This is a followup to my earlier series, which has been partially applied already. Other patches that became obsolete by unrelated refactoring have been dropped.

The review comments have been addressed. The nullptr patch should now be complete and catch every "0" in qconf.cc and qconf.h. One additional patch has been added that removes a constructor overload that would have needed this treatment otherwise as well.

Regards,

Eike

Signature · 13 lines
Rolf Eike Beer

emlix GmbH
Headquarters: Berliner Str. 12, 37073 Göttingen, Germany
Phone +49 (0)551 30664-0, e-mail [email protected]
District Court of Göttingen, Registry Number HR B 3160
Managing Directors: Heike Jordan, Dr. Uwe Kracke
VAT ID No. DE 205 198 055
Office Berlin: Panoramastr. 1, 10178 Berlin, Germany
Office Bonn: Bachstr. 6, 53115 Bonn, Germany
http://www.emlix.com

emlix - your embedded Linux partner