Skip to content

mm: page_vma_mapped_walk() cleanup and THP fixes

Hugh Dickins linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 30 repliesIn review 10 of 11 applied

Patches in v1 10 of 11 applied

#Subject and filesSizeRepliesApplied
1/11mm: page_vma_mapped_walk(): use page for pvmw->pagemm/page_vma_mapped.c+4 -54 repliesApplied
2/11mm: page_vma_mapped_walk(): settle PageHuge on entrymm/page_vma_mapped.c+8 -43 repliesApplied
3/11mm: page_vma_mapped_walk(): use pmd_read_atomic()mm/page_vma_mapped.c+4 -110 replies
4/11mm: page_vma_mapped_walk(): use pmde for *pvmw->pmdmm/page_vma_mapped.c+6 -52 repliesApplied
5/11mm: page_vma_mapped_walk(): prettify PVMW_MIGRATION blockmm/page_vma_mapped.c+14 -162 repliesApplied
6/11mm: page_vma_mapped_walk(): crossing page table boundarymm/page_vma_mapped.c+4 -43 repliesApplied
7/11mm: page_vma_mapped_walk(): add a level of indentationmm/page_vma_mapped.c+56 -531 replyApplied
8/11mm: page_vma_mapped_walk(): use goto instead of while (1)mm/page_vma_mapped.c+3 -41 replyApplied
9/11mm: page_vma_mapped_walk(): get vma_address_end() earliermm/page_vma_mapped.c+9 -41 replyApplied
10/11mm/thp: fix page_vma_mapped_walk() if THP mapped by ptesmm/page_vma_mapped.c+25 -91 replyApplied
11/11mm/thp: another PVMW_SYNC fix in page_vma_mapped_walk()mm/page_vma_mapped.c+4 -02 repliesApplied

Reviews trailers per patch

10 of 11 patches have a Reviewed-by or Acked-by.

PatchAlistair PoppleKirill A. ShutemovPeter XuWang Yugui
1/11R-b A-b R-b
2/11A-b R-b
3/11
4/11A-b R-b
5/11A-b R-b
6/11A-b
7/11A-b
8/11A-b
9/11A-b
10/11A-b
11/11A-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 00/11] mm: page_vma_mapped_walk() cleanup and THP fixes

Here is the promised splitup of what I posted a few days ago as 5/7 mm/thp: fix page_vma_mapped_walk() if huge page mapped by ptes.

These are against 5.13-rc5 plus yesterday's mm/thp series:
https://lore.kernel.org/linux-mm/[email protected]/T/#u
(sorry about the misthreading, I missed linux-mm and lkml at first). 03/10 and 04/10 of that series also touched mm/page_vma_mapped.c.

I've marked all of these for stable: many are merely cleanups, but I think they are much better before the main fix than after.

01/11 makes the opposite cleanup to the earlier 5/7: that preferred to use pvmw->page, this prefers to use page - it could go either way. 11/11 is a new fix that I noticed while splitting up.

01/11 mm: page_vma_mapped_walk(): use page for pvmw->page 02/11 mm: page_vma_mapped_walk(): settle PageHuge on entry 03/11 mm: page_vma_mapped_walk(): use pmd_read_atomic() 04/11 mm: page_vma_mapped_walk(): use pmde for *pvmw->pmd 05/11 mm: page_vma_mapped_walk(): prettify PVMW_MIGRATION block 06/11 mm: page_vma_mapped_walk(): crossing page table boundary 07/11 mm: page_vma_mapped_walk(): add a level of indentation 08/11 mm: page_vma_mapped_walk(): use goto instead of while (1) 09/11 mm: page_vma_mapped_walk(): get vma_address_end() earlier 10/11 mm/thp: fix page_vma_mapped_walk() if THP mapped by ptes 11/11 mm/thp: another PVMW_SYNC fix in page_vma_mapped_walk()

 mm/page_vma_mapped.c |  160 +++++++++++++++++++++++++++------------------
 1 file changed, 96 insertions(+), 64 deletions(-)

Hugh