introduce Rockchip rockusb
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest1 of 3 patches 0 repliesNew
1 of 3 patches is in this archive. The cover letter announces 3.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | drivers: usb: gadget: add the rockusb gadget | +0 | 3 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [U-Boot] [U-Boot 0/3] introduce Rockchip rockusb
Hi Marek,
Quoted 17 lines · Marek Vasut
Quoted 16 lines · Simon Glass
Hi Marek,
Quoted 13 lines · Marek Vasut
Quoted 12 lines · Eddie Cai
2017-03-17 5:26 GMT+08:00 Marek Vasut <[email protected]>:
Quoted 7 lines · Eddie Cai
Quoted 1 line
rockusb is a protocol run between host pc and device. it help people get
device
Quoted 1 line
info, flash image to device. this patch implement rockusb on device side.
What is the benefit of this yet-another NIH protocol compared to ie. DFU/UMS/Thor/Fastboot ?
This is mostly used on Rockchip chipset. All the rockchip SoC boot rom and develop tools implement this protocol.
So we want to use the same protocol which compatible with current tools.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
This does not really answer my question. We have protocols which implement exactly this functionality already, why do we need another one ?
I think the point is that this is widely used with Rockchip devices, and for mainline U-Boot to be fully useful it needs to support it.
OK, I'll leave that decision to Lukasz . I'm not a big fan of adding redundant functionality only because someone thought NIH is good before looking at standards.
I don't know how you define "redundant functionality", from the gadget framework view,
yes, it's very similar to other storage based gadget, we may able to re-use the common part of the framework.
But it's definitely a different USB class driver which is used in Rockchip bootrom
and Rockchip loader, and some commands like RD(Reset device), DB(download boot)
are not able to use in ums or fastboot, but they are useful in Rockchip platform.
Thanks,
- Kever
Quoted 4 lines
Quoted 2 lines
However I do think it would be good to move to using DFU etc. if possible?
Yes.