Skip to content

VSOCK: support mergeable rx buffer in vhost-vsock

jiangyiwen kvm netdev virtualization 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 56 repliesIn review
  2. v15 patches 42 repliesSuperseded

Changes in v2 from the cover letter

* Addressed comments from Jason Wang.
* Add performance test result independently.
* Use Skb_page_frag_refill() which can use high order page and reduce the stress of page allocator.
* Still use fixed size(PAGE_SIZE) to fill rx buffer, because too small size can't fill one full packet, we only 128 vq num now.
* Use iovec to replace buf in struct virtio_vsock_pkt, keep tx and rx consistency.
* Add virtio_transport ops to get max pkt len, in order to be compatible with old version.
---

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5VSOCK: support fill mergeable rx buffer in guestinclude/linux/virtio_vsock.h net/vmw_vsock/virtio_transport.c+92 -234 replies
1/5VSOCK: support fill mergeable rx buffer in guestinclude/linux/virtio_vsock.h net/vmw_vsock/virtio_transport.c+92 -230 replies
2/5VSOCK: support fill data to mergeable rx buffer in hostdrivers/vhost/vsock.c include/linux/virtio_vsock.h include/uapi/linux/virtio_vsock.h+94 -2325 replies
2/5VSOCK: support fill data to mergeable rx buffer in hostdrivers/vhost/vsock.c include/linux/virtio_vsock.h include/uapi/linux/virtio_vsock.h+94 -230 replies
3/5VSOCK: support receive mergeable rx buffer in guestdrivers/vhost/vsock.c include/linux/virtio_vsock.h net/vmw_vsock/virtio_transport.c +1 more+166 -3511 replies
3/5VSOCK: support receive mergeable rx buffer in guestdrivers/vhost/vsock.c include/linux/virtio_vsock.h net/vmw_vsock/virtio_transport.c +1 more+166 -350 replies
4/5VSOCK: increase send pkt len in mergeable mode to improve performancedrivers/vhost/vsock.c include/linux/virtio_vsock.h net/vmw_vsock/virtio_transport.c +1 more+53 -80 replies
4/5VSOCK: increase send pkt len in mergeable mode to improve performancedrivers/vhost/vsock.c include/linux/virtio_vsock.h net/vmw_vsock/virtio_transport.c +1 more+53 -80 replies
5/5VSOCK: batch sending rx buffer to increase bandwidthdrivers/vhost/vsock.c+17 -74 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/5] VSOCK: support mergeable rx buffer in vhost-vsock

Now vsock only support send/receive small packet, it can't achieve high performance. As previous discussed with Jason Wang, I revisit the idea of vhost-net about mergeable rx buffer and implement the mergeable rx buffer in vhost-vsock, it can allow big packet to be scattered in into different buffers and improve performance obviously.

This series of patches mainly did three things:
- mergeable buffer implementation
- increase the max send pkt size
- add used and signal guest in a batch

And I write a tool to test the vhost-vsock performance, mainly send big packet(64K) included guest->Host and Host->Guest. I test performance independently and the result as follows:

Before performance:

              Single socket            Multiple sockets(Max Bandwidth)
Guest->Host   ~400MB/s                 ~480MB/s
Host->Guest   ~1450MB/s                ~1600MB/s

After performance only use implement mergeable rx buffer:

              Single socket            Multiple sockets(Max Bandwidth)
Guest->Host   ~400MB/s                 ~480MB/s
Host->Guest   ~1280MB/s                ~1350MB/s

In this case, max send pkt size is still limited to 4K, so Host->Guest performance will worse than before.

After performance increase the max send pkt size to 64K:

              Single socket            Multiple sockets(Max Bandwidth)
Guest->Host   ~1700MB/s                ~2900MB/s
Host->Guest   ~1500MB/s                ~2440MB/s

After performance all patches are used:

              Single socket            Multiple sockets(Max Bandwidth)
Guest->Host   ~1700MB/s                ~2900MB/s
Host->Guest   ~1700MB/s                ~2900MB/s

From the test results, the performance is improved obviously, and guest memory will not be wasted.

In addition, in order to support mergeable rx buffer in virtio-vsock, we need to add a qemu patch to support parse feature.

---
v1 -> v2:
* Addressed comments from Jason Wang.
* Add performance test result independently.
* Use Skb_page_frag_refill() which can use high order page and reduce the stress of page allocator.
* Still use fixed size(PAGE_SIZE) to fill rx buffer, because too small size can't fill one full packet, we only 128 vq num now.
* Use iovec to replace buf in struct virtio_vsock_pkt, keep tx and rx consistency.
* Add virtio_transport ops to get max pkt len, in order to be compatible with old version.
---

Yiwen Jiang (5):
VSOCK: support fill mergeable rx buffer in guest
VSOCK: support fill data to mergeable rx buffer in host
VSOCK: support receive mergeable rx buffer in guest
VSOCK: increase send pkt len in mergeable mode to improve performance
VSOCK: batch sending rx buffer to increase bandwidth

 drivers/vhost/vsock.c                   | 183 ++++++++++++++++++++-----
 include/linux/virtio_vsock.h            |  13 +-
 include/uapi/linux/virtio_vsock.h       |   5 +
 net/vmw_vsock/virtio_transport.c        | 229 +++++++++++++++++++++++++++-----
 net/vmw_vsock/virtio_transport_common.c |  66 ++++++---
 5 files changed, 411 insertions(+), 85 deletions(-)
Signature · 6 lines
1.8.3.1

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization