C API: .needs_cmds and SAFE_RUN_CMD()
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 6 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 6 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [LTP] [PATCH 0/6] C API: .needs_cmds and SAFE_RUN_CMD()
Quoted 51 lines · Li Wang
Hi Xiao,
On Sun, Mar 29, 2020 at 1:36 PM Xiao Yang <[email protected] <mailto:[email protected]>> wrote:
On 2020/3/28 11:42, Petr Vorel wrote:
> Hi Xiao,
>
>> On 3/28/20 5:39 AM, Petr Vorel wrote:
>>> + There is a double check (first in
>>> .needs_cmds, then inSAFE_RUN_CMD()), maybe that's not needed. >
>> Hi Petr,
>
>> Why do you need the duplicate .needs_cmds flag?(it introduces
the double
>> check as you said)
>
>> Usually, all tests run commands by tst_run_cmd()/SAFE_RUN_CMD()
and they can
>> report TCONF
>
>> by passingTST_RUN_CMD_CHECK_CMDso it is fair to be a part of >> tst_run_cmd()/SAFE_RUN_CMD().
>
> Thanks for your review.
> I guess Cyril will prefer .needs_cmds, as it can be parsed -
metadata project:
> https://people.kernel.org/metan/towards-parallel-kernel-test-runs
> https://github.com/metan-ucw/ltp/tree/master/docparse
Hi Petr?Thank you for sharing these info.
Does Cyril want to get metadata from structtst_testdirectly?How about the rough design?
1) .needs_cmds only saves the required commands.(doesn't do any check)
2) pass the corresponding member of .needs_cmds to tst_run_cmd()/SAFE_RUN_CMD()(do check in these functions). For example:
----------------------------------------------
# greptst_needs_cmdsinclude/tst_cmd.h
extern const char *const*tst_needs_cmds;# grep -B1
tst_needs_cmdslib/tst_test.cconst char *const
*tst_needs_cmds;
--
if (tst_test->needs_cmds)
tst_needs_cmds=tst_test->needs_cmds;
Quoted 7 lines
# grep -A2 '
needs_cmds'testcases/kernel/syscalls/add_key/add_key05.cconst char *const cmd_useradd[] = {tst_needs_cmds[0], username, NULL}; int rc;I don't see any advantage of involving this struct in a test case, and it also makes things more complicated.
Hi Li,
In fact, I perfer to remove .need_cmd and use tst_run_cmd with/without TST_RUN_CMD_CHECK_CMD directly.
But I am not sure if it is necessary to keep .need_cmd for metadata project. I think we can generate json about resouce by reading struct tst_test or other ways.
Thanks,
Xiao Yang
Quoted 13 lines
IMO, the '.needs_cmds' should do check and guarantee all the cmds exist. That's a hard requirement for the test. If a situation that the commands are only part of the requirement(soft), we could avoid using '.needs_cmds' in the test and just calling
tst_run_cmd()without passingTST_RUN_CMD_CHECK_CMDflag. This satisfies most situations we have, it is safe enough and choosable for people.Or maybe I'm wrong here too:).
--
Regards,
Li Wang