C API: .needs_cmds and SAFE_RUN_CMD()
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 6 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 6 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [LTP] [PATCH 0/6] C API: .needs_cmds and SAFE_RUN_CMD()
Quoted 16 lines · Petr Vorel
Hi Xiao,
Quoted 6 lines
Quoted 6 lines
# grep -A2 'needs_cmds' testcases/kernel/syscalls/add_key/add_key05.c const char *const cmd_useradd[] = {tst_needs_cmds[0], username, NULL}; int rc;I don't see any advantage of involving this struct in a test case, and it also makes things more complicated.
Quoted 7 lines
Hi Li,
In fact, I perfer to remove .need_cmd and use
tst_run_cmdwith/withoutTST_RUN_CMD_CHECK_CMDdirectly.
But I am not sure if it is necessary to keep .need_cmd for metadata project. I think we can generate json about resouce by reading structtst_testor other ways.
Quoted 9 lines
not sure if you mean removing .needs_cmds entirely or just for
copy_file_range02.c. or some other test. I rewritten the original patchset because Cyril suggested .needs_cmds implementation:"Actually I would like to avoid exposing the function to the tests and force people to use the .needs_cmds instead in order to have a proper metadata." [1]
Hi Petr,
Thanks a lot for your explanation.
I want to remove .needs_cmds entirely before but it may be helpful to get metadata about command.
Thanks,
Xiao Yang
Quoted 37 lines
IMHO parsing struct members is easier to get metadata than searching for various functions to be used, so I understand Cyril's intention. Cyril explains this on his blog posts (I've noticed [2], but it's also in [3]: "this arrangement also helps to export the test metadata into a machine parsable format").
Kind regards,
PetrQuoted 16 lines
Thanks,
Xiao YangQuoted 12 lines
IMO, the '.needs_cmds' should do check and guarantee all the cmds exist. That's a hard requirement for the test. If a situation that the commands are only part of the requirement(soft), we could avoid using '.needs_cmds' in the test and just calling
tst_run_cmd()without passingTST_RUN_CMD_CHECK_CMDflag. This satisfies most situations we have, it is safe enough and choosable for people.Or maybe I'm wrong here too:).
--
Regards,
Li WangKind regards,
Petr[1] https://lists.linux.it/pipermail/ltp/2020-March/016233.html
[2] https://people.kernel.org/metan/towards-parallel-kernel-test-runs
[3] https://people.kernel.org/metan/the-ltp-test-driver-model.