Unify error handling in LTP library
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 of 19 patches 0 repliesNew
6 of 19 patches are in this archive. The cover letter announces 19.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/19 | Unify error handling in lib/tst_safe_macros.c | +0 | 0 replies | |
| 2/19 | Unify error handling in lib/tst_safe_sysv_ipc.c | +0 | 0 replies | |
| 3/19 | Unify error handling in lib/tst_safe_timerfd.c | +0 | 1 reply | |
| 3/19 | Unify error handling in lib/tst_safe_timerfd.c | +0 | 1 reply | |
| 5/19 | Unify error handling in lib/safe_macros.c | +0 | 1 reply | |
| 11/19 | Unify error handling in lib/tst_fs_setup.c | +0 | 0 replies |
Reviews trailers per patch
1 of 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Yang Xu |
|---|---|
| Series | A-b |
| 1/19 | A-b |
| 2/19 | |
| 3/19 | |
| 3/19 | |
| 5/19 | |
| 11/19 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [LTP] [PATCH 00/19] Unify error handling in LTP library
Hi Martin
I have seen the patchset and send some comments on 2,3,5,11 patch, for the patchset, you can add Acked-by.
Best Regard
Yang Xu
Quoted 52 lines
LTP helper functions, mainly safe syscalls, often report two different source code locations in error messages and sometimes handle syscall return values incorrectly. This patchset unifies source code location formatting to only show the calling line in the test program and fixes invalid return value handling. Safe syscalls now make pedantic distinction between common errors and invalid return values where applicable.
Some safe syscalls returned no value so they were not usable in test cleanup. This is also fixed along with potential control flow issues when
tst_brk()does not immediately terminate the program.Martin Doucha (19):
Unify error handling inlib/tst_safe_macros.cUnify error handling inlib/tst_safe_sysv_ipc.cUnify error handling inlib/tst_safe_timerfd.cUnify error handling inlib/safe_file_ops.cUnify error handling inlib/safe_macros.cUnify error handling inlib/safe_net.c
Unify error handling inlib/safe_stdio.cUnify error handling inlib/tst_mkfs.c
Unify error handling inlib/tst_checkpoint.cUnify error handling inlib/tst_net.c
Unify error handling inlib/tst_fs_setup.cUnify error handling ininclude/tst_safe_clocks.hMove executable code out oftst_safe_macros.hUnify error handling in moved functions Unify error handling ininclude/tst_safe_macros.hUnify error handling ininclude/tst_safe_posix_ipc.hUnify error handling ininclude/tst_safe_prw.hUnify error handling inlib/tst_resource.cUnify error handling ininclude/lapi/safe_rt_signal.hinclude/lapi/safe_rt_signal.h | 25 +- include/safe_file_ops_fn.h | 8 +- include/tst_safe_clocks.h | 48 ++- include/tst_safe_macros.h | 130 ++++---- include/tst_safe_posix_ipc.h | 6 +- include/tst_safe_prw.h | 16 +- lib/safe_file_ops.c | 207 +++++++----- lib/safe_macros.c | 602 ++++++++++++++++++++++------------ lib/safe_net.c | 262 +++++++++------ lib/safe_stdio.c | 34 +- lib/tst_checkpoint.c | 23 +- lib/tst_fs_setup.c | 8 +- lib/tst_mkfs.c | 36 +- lib/tst_net.c | 9 +- lib/tst_resource.c | 9 +- lib/tst_safe_macros.c | 201 ++++++++++-- lib/tst_safe_sysv_ipc.c | 79 +++-- lib/tst_safe_timerfd.c | 32 +- 18 files changed, 1100 insertions(+), 635 deletions(-)