Skip to content

ARM: vf610: Suspend/resume support

Stefan Agner linux-arm-kernel linux-gpio lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 9 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 9 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] ARM: vf610: Suspend/resume support

Hi Bill, Hi Shawn,

Am 2014-09-28 05:08, schrieb Shawn Guo:

Quoted 69 lines · Bill Pringlemeir
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

I think that Shawn Guo already did a patchset to remove stuff from the vf610.dtsi to the machine/configuration DT files.

Do you mean the pin configuration? That's really more board-specific. But IP block/device is not really the case.

Quoted 11 lines

In this patchset, I suggested that we could include the notation in the headers which are included in the 'DT' files. So instead of 'dtsi', we could use,

   #define VF610_GPC_SUPPORT \
           gpc: gpc at 4006c000 {                \
                   compatible = "fsl,vf610-gpc"; \
                   reg = <0x4006c000 0x1000>;    \
           };
Quoted 3 lines

Or even,

   #define VF610_SUSPEND_DT_SUPPORT \ ...

I don't think this will be accepted by DT maintainers. We have already got some objections when we define pin function ID as multiple integers. They expect the DT macro is used for single integer case.

Quoted 37 lines

Anyways, the DT issue doesn't matter so much. People will have to make custom versions for their own boards. Although, I don't think it is not that hard to support it at the machine level.

I agree that so far there are some peripherals that make it difficult to run the mainline Linux with an MQX. However, I think this patch set seems to bring it closer to making it impossible. I am only suggesting that we make it a configuration option and not include it for all Vybrid devices.

Is it clear that the desired way is to use,

   &gpc { status = "disabled"; };
   &src { status = "disabled"; };

We have,

arch/arm/mach-imx/gpc.c

      void __init vf610_gpc_init(void)
      {
              struct device_node *np;

              np = of_find_compatible_node(NULL, NULL, "fsl,vf610-gpc");
              gpc_base = of_iomap(np, 0);
              gpc_imr_base = gpc_base + VF610_GPC_IMR1;

...

arch/arm/mach-imx/mach-vf610.c

   static void __init vf610_init_irq(void)
   {
           vf610_gpc_init();
           irqchip_init();
   }
Quoted 5 lines
   ...

   +	.init_irq	= vf610_init_irq,

I don't think this will work.

Quoted 9 lines

Yes, you're right. But I guess this can be fixed by an additional of_device_is_available() check after of_find_compatible_node() call.

Quoted 2 lines

Not to mention that 'mach-vf610.c' will
not build if HAVE_IMX_GPC is not defined.

HAVE_IMX_GPC cannot be configured out, because it's selected by SOC_VF610.

Maybe we can make that optional when CONFIG_PM is on, e.g. select HAVE_IMX_GPC if PM

The GPC module is all about power management, hence in case we want the M4 taken care of that, we just have to configure a Linux kernel without CONFIG_PM support.

Quoted 14 lines
Quoted 4 lines

Also, I don't really see a
use of the GPC module unless suspend/resume is active? Even some wall
powered designs may wish to exclude this functionality?

Quoted 9 lines

I think that the SRC maybe needed for secure parts. I think that some designs might wish to restrict Linux's access to these registers as well. I don't actually see why we need this module? I think the imx6 needs it due to multi-CPU bring-up, but in the Vybrid case, this does not exist. Can you check to see why we need the SRC? I don't see where we actually use it? In patch9/9, we record it but do we actually access the registers? Is it just for the vf610_src_init() code? Even that seems the whole 'src.c' file is only needed for the 'src_base' reference, which we don't use?

Quoted 2 lines

+1. I'm also wondering how SRC is used by suspend routine in this series.

Well I tried to bring LPStop modes to work, which would need GPR0/GPR1 registers of SRC. If I have it working in the next series, I will need that, but if not, I will drop those changes.

--
Stefan