Skip to content

Stop calling devm_request_irq() with invalid IRQs in the USB drivers

Sergey Shtylyov linux-amlogic linux-arm-kernel linux-arm-msm linux-samsung-soc linux-usb 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest4 of 9 patches 8 repliesIn review

4 of 9 patches are in this archive. The cover letter announces 9.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9usb: dwc3: meson-g12a: add IRQ checkdrivers/usb/dwc3/dwc3-meson-g12a.c+2 -02 replies
2/9usb: dwc3: qcom: add IRQ checkdrivers/usb/dwc3/dwc3-qcom.c+4 -01 reply
3/9usb: gadget: udc: at91: add IRQ checkdrivers/usb/gadget/udc/at91_udc.c+3 -11 reply
4/9usb: gadget: udc: s3c2410: add IRQ checkdrivers/usb/gadget/udc/at91_udc.c+3 -12 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchMartin BlumenstinglFelipe Balbi
1/9R-b A-b
2/9A-b
3/9
4/9A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/9] Stop calling devm_request_irq() with invalid IRQs in the USB drivers

Here are 9 patches against the 'usb-linus' branch of GregKH's 'usb.git' repo. The affected drivers call platform_get_irq() but largely ignore its result -- they blithely pass the negative error codes to request_irq() (and its ilk) which expects *unsinged* IRQ #s. Stop doing that by checking what exactly platform_get_irq() returns.

[1/9] usb: dwc3: meson-g12a: add IRQ check [2/9] usb: dwc3: qcom: add IRQ check [3/61] usb: gadget: udc: at91: add IRQ check [4/9] usb: gadget: udc: s3c2410: add IRQ check [5/9] usb: host: ohci-tmio: add IRQ check [6/9] usb: misc: brcmstb-usb-pinmap: add IRQ check [7/9] usb: phy: fsl-usb: add IRQ check [8/9] usb: phy: tahvo: add IRQ check
[9/9] usb: phy: twl6030: add IRQ checks