Skip to content

cpufreq: intel_pstate: Handle powersave governor correctly in the passive mode with HWP

Rafael J. Wysocki linux-pm lkml 3 versions – In review

Get series with b4
b4 am 11312387.r5AVKgp8zO@kreacher

Versions newest first · linked by author and title

  1. v3 Latest4 patches 1 replyIn review
  2. v24 patches 6 repliesSuperseded
  3. v12 patches 5 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4cpufreq: Introduce governor flagsdrivers/cpufreq/cpufreq.c drivers/cpufreq/cpufreq_governor.h include/linux/cpufreq.h +1 more+10 -50 replies
2/4cpufreq: Introduce CPUFREQ_GOV_STRICT_TARGETdrivers/cpufreq/cpufreq_performance.c drivers/cpufreq/cpufreq_powersave.c include/linux/cpufreq.h+5 -00 replies
3/4cpufreq: Add strict_target to struct cpufreq_policydrivers/cpufreq/cpufreq.c include/linux/cpufreq.h+8 -00 replies
4/4cpufreq: intel_pstate: Take CPUFREQ_GOV_STRICT_TARGET into accountdrivers/cpufreq/intel_pstate.c+9 -70 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchViresh Kumar
1/4A-b
2/4A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] cpufreq: intel_pstate: Handle powersave governor correctly in the passive mode with HWP

Hi,

Quoted 9 lines · CET Rafael J. Wysocki

Even after the changes made very recently, the handling of the powersave governor is not exactly as expected when intel_pstate operates in the "passive" mode with HWP enabled.

Namely, in that case HWP is not limited to the policy min frequency, but it can scale the frequency up to the policy max limit and it cannot be constrained currently, because there are no provisions for that in the framework.

Quoted 7 lines

To address that, patches [1-3/4] add a new governor flag to indicate that this governor wants the target frequency to be set to the exact value passed to the driver, if possible, and change the powersave and performance governors to have that flag set.

The last patch makes intel_pstate take that flag into account when programming the HWP Request MSR.

The v3 simply uses different names for the new governor flags.

Thanks!