tools/sunxi: Use mkimage for SPL generation
Get series with b4
b4 am 76666159.qhDbUPrvfj@kistaVersions newest first
- v4 Latest0 of 3 patches 0 repliesNew
Patches in v4 No applies recorded yet
None of the 3 patches the cover letter announces are in this archive.
Reviews trailers per patch
| Patch | Jernej Skrabec |
|---|---|
| Series | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [linux-sunxi] [PATCH v4 0/3] tools/sunxi: Use mkimage for SPL generation
Dne sreda, 06. januar 2021 ob 10:24:35 CET je Andre Przywara napisal(a):
Quoted 23 lines
Hi,
a small update fixing the strncpy bug and addressing too long DT names properly. Thanks to Samuel for pointing this out.
==================So far creating a bootable SPL image for Allwinner based boards uses the mksunxiboot tool. Most other platforms seemed to have integrated this kind of functionality into the common mkimage tool.
Since there is nothing special about the Allwinner image in this respect, just add support for the so-called "eGON" image type into mkimage. If there was a particular reason this hasn't been done before, please let me know.
This will eventually allow us to remove mksunxiboot, but I leave it around for now in case of regressions and since some people depend on it from external projects.
Patch 1/3 splits some existing sunxi specific header file, so we can share the eGON header definition between the tools and the SPL. Patch 2/3 adds the actual support to mkimage, patch 3/3 then switches the
Makefileto use mkimage instead of mksunxiboot.
Quoted 8 lines
I tested all 152 Allwinner boards by building each u-boot-sunxi-with-spl.bin and comparing them against the version created using mksunxiboot (using
SOURCE_DATE_EPOCHand .scmversion to create reproducible builds, and by reverting just patch 3/3).
All files before and after were identical.Cheers,
Andre
Whole series is:
Best regards,
Jernej
Quoted 21 lines
Changelog v3 .. v4:
- properly check DT name length before inserting into headerChangelog v2 .. v3:
- factor out eGON struct into separate header file
- only print extended header information when applicable
- remove redundant alignment
- minor cosmetic fixesChangelog v1 .. v2:
- Drop already merged cleanup patch (v1 1/3)
- replace relative include path
- remove already defined ALIGN macro
- rebase against current masterAndre Przywara (3):
sunxi: Factor out eGON BROM header description
tools: mkimage: Add Allwinner eGON support
sunxi: Use mkimage for SPL boot image generation
Quoted 16 lines
arch/arm/include/asm/arch-sunxi/spl.h | 65 +----------- common/image.c | 1 + include/image.h | 1 + include/sunxi_image.h | 82 ++++++++++++++++ scripts/Makefile.spl | 8 +- tools/Makefile | 1 + tools/sunxi_egon.c | 136 ++++++++++++++++++++++++++ 7 files changed, 226 insertions(+), 68 deletions(-) create mode 100644 include/sunxi_image.h create mode 100644 tools/sunxi_egon.cSignature · 4 lines
2.17.5 -- You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send an
email to linux-sunxi+unsubscribe at googlegroups.com.
Quoted 1 line
To view this discussion on the web, visit https://groups.google.com/d/msgid/
linux-sunxi/20210106092438.3438-1-andre.przywara%40arm.com.