Skip to content

Add TST_NET_IPV{4, 6}_ONLY and use on broken_ip

Alexey Kodanev ltp 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
2/2broken_ip: TCONF when test run on unsupported protocol+0 -02 replies
2/2broken_ip: TCONF when test run on unsupported protocol+0 -02 replies
2/2broken_ip: TCONF when test run on unsupported protocol+0 -02 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchAlexey Kodanev
2/2R-b
2/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [LTP] [PATCH 0/2] Add TST_NET_IPV{4, 6}_ONLY and use on broken_ip
Quoted 6 lines · Petr Vorel

Hi Alexey,

https://github.com/linux-test-project/ltp/issues/843

does it make sense to run it on IPv4 and broken_ip-totlen on IPv6? Both don't break but not in runtest file.

Hi Petr,

Yes it should work with the -L option, but these tests are the same (differs the descriptions for IPv4/IPv6):

broken_ip-totlen renamed from broken_ip-plen +1 -1
diff -u broken_ip-plen broken_ip-totlen
@@ -10,7 +10,7 @@
 
 do_test()
 {
-	tst_res TINFO "Sending ICMPv$TST_IPVER with wrong payload len for $NS_DURATION sec"
+	tst_res TINFO "Sending ICMPv$TST_IPVER with wrong total len field for $NS_DURATION sec"
 	tst_icmp -t $NS_DURATION -s "0 100 500 1000 $NS_ICMP_SENDER_DATA_MAXSIZE" -L
 	tst_ping
 }

So broken_ip-totlen should be just removed.

Quoted 17 lines

Kind regards,
Petr

Petr Vorel (2):
tst_net.sh: Add variable for supported protocol
broken_ip: TCONF when test run on unsupported protocol

 testcases/lib/tst_net.sh                              | 8 ++++++++
 testcases/lib/tst_test.sh                             | 2 +-
 testcases/network/stress/broken_ip/broken_ip-checksum | 3 ++-
 testcases/network/stress/broken_ip/broken_ip-fragment | 3 ++-
 testcases/network/stress/broken_ip/broken_ip-ihl      | 3 ++-
 testcases/network/stress/broken_ip/broken_ip-nexthdr  | 3 ++-
 testcases/network/stress/broken_ip/broken_ip-protcol  | 3 ++-
 7 files changed, 19 insertions(+), 6 deletions(-)