Skip to content

ethtool: add support for EEE linkmodes beyond bit 32

Heiner Kallweit netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ethtool: add struct ethtool_keee and extend struct ethtool_eeeinclude/linux/ethtool.h include/uapi/linux/ethtool.h+21 -17 replies
2/5ethtool: add basic handling of struct ethtool_keeenet/ethtool/eee.c+18 -110 replies
3/5ethtool: send EEE linkmode bitmaps to userspacenet/ethtool/eee.c+35 -130 replies
4/5net: phy: c45: prepare genphy_c45_ethtool_set_eee for follow-up extensiondrivers/net/phy/phy-c45.c+20 -210 replies
5/5net: phy: c45: extend genphy_c45_ethtool_[set|get]_eeedrivers/net/phy/phy-c45.c+17 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/5] ethtool: add support for EEE linkmodes beyond bit 32

So far only 32bit legacy bitmaps are passed to userspace. This makes it impossible to manage EEE linkmodes beyond bit 32, e.g. manage EEE for 2500BaseT and 5000BaseT. This series adds support for passing full linkmode bitmaps between kernel and userspace.

Fortunately the netlink-based part of ethtool is quite smart and no changes are needed in ethtool. However this applies to the netlink interface only, the ioctl interface for now remains restricted to legacy bitmaps.

Next step will be adding support for the c45 EEE2 standard registers (3.21, 7.62, 7.63) to the genphy_c45 functions dealing with EEE. I have a follow-up series for this ready to be submitted.

Heiner Kallweit (5):
ethtool: add struct ethtool_keee and extend struct ethtool_eee
ethtool: add basic handling of struct ethtool_keee
ethtool: send EEE linkmode bitmaps to userspace
net: phy: c45: prepare genphy_c45_ethtool_set_eee for follow-up
extension
net: phy: c45: extend genphy_c45_ethtool_[set|get]_eee

 drivers/net/phy/phy-c45.c    | 57 +++++++++++++++++----------
 include/linux/ethtool.h      | 18 +++++++++
 include/uapi/linux/ethtool.h |  4 +-
 net/ethtool/eee.c            | 75 +++++++++++++++++++++++++-----------
 4 files changed, 109 insertions(+), 45 deletions(-)
Signature · 1 line
2.43.0