Skip to content

md/dm-crypt: Fine-tuning for five function implementations

SF Markus Elfring alsa-devel ath9k-devel ceph-devel dm-devel dri-devel intel-wired-lan kernel-janitors kvm kvm-ppc linux-acpi linux-arm-kernel linux-clk linux-crypto linux-gpio linux-i2c linux-ide linux-iio linux-input linux-m68k linux-media linux-mmc linux-mtd linux-omap linux-raid linux-rdma linux-renesas-soc linux-rtc linux-s390 linux-scsi linux-wireless linuxppc-dev lkml ltp lustre-devel netdev qemu-devel sparclinux virtualization xen-devel 1 version NAK

Status from this message: Nack.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 12 repliesNAK

Patches in v1

#Subject and filesSizeRepliesApplied
1/10md/dm-crypt: Use kcalloc() in crypt_alloc_tfms()drivers/md/dm-crypt.c+1 -20 replies
2/10md/dm-crypt: Reduce the scope for a variable in crypt_alloc_tfms()drivers/md/dm-crypt.c+2 -20 replies
3/10md/dm-crypt: Rename a jump label in crypt_message()drivers/md/dm-crypt.c+2 -310 replies
4/10md/dm-crypt: Delete an unnecessary variable initialisation in crypt_message()drivers/md/dm-crypt.c+1 -10 replies
5/10md/dm-crypt: Rename a jump label in crypt_set_key()drivers/md/dm-crypt.c+4 -51 reply
6/10md/dm-crypt: Delete an unnecessary variable initialisation in crypt_set_key()drivers/md/dm-crypt.c+1 -10 replies
7/10md/dm-crypt: Rename a jump label in crypt_iv_tcw_whitening()drivers/md/dm-crypt.c+4 -40 replies
8/10md/dm-crypt: Return directly after a failed crypto_alloc_ahash() in crypt_iv_essiv_ctr()drivers/md/dm-crypt.c+1 -20 replies
9/10md/dm-crypt: Two checks and one function call less in crypt_iv_essiv_ctr() after error detectiondrivers/md/dm-crypt.c+3 -60 replies
10/10md/dm-crypt: Delete unnecessary variable initialisations in crypt_iv_essiv_ctr()drivers/md/dm-crypt.c+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] md/dm-crypt: Fine-tuning for five function implementations

From: Markus Elfring <[email protected]>
Date: Wed, 28 Sep 2016 17:25:17 +0200

Some update suggestions were taken into account
from static source code analysis.

Markus Elfring (10):
Use kcalloc() in crypt_alloc_tfms()
Reduce the scope for a variable in crypt_alloc_tfms()
Rename a jump label in crypt_message()
Delete an unnecessary variable initialisation in crypt_message() Rename a jump label in crypt_set_key()
Delete an unnecessary variable initialisation in crypt_set_key() Rename a jump label in crypt_iv_tcw_whitening()
Return directly after a failed crypto_alloc_ahash() in crypt_iv_essiv_ctr() Two checks and one function call less in crypt_iv_essiv_ctr() after error detection Delete unnecessary variable initialisations in crypt_iv_essiv_ctr()

 drivers/md/dm-crypt.c | 51 ++++++++++++++++++++++-----------------------------
 1 file changed, 22 insertions(+), 29 deletions(-)
Signature · 1 line
2.10.0