Skip to content

PM / Sleep / Runtime: Fixup some driver's system suspend

Kevin Hilman linux-arm-kernel linux-pm 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 8 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 8 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] PM / Sleep / Runtime: Fixup some driver's system suspend
Quoted 46 lines · Ulf Hansson
Quoted 45 lines · Rafael J. Wysocki
Quoted 26 lines · Kevin Hilman
Quoted 13 lines · Ulf Hansson

Patch 1 -> 2:
These patches provides two new runtime PM helper functions which intend to be used from system suspend/resume callbacks, to make sure devices are put into low power state during system suspend and brought back to full power at system resume.

The prerequisite is to have all levels of a device's runtime PM callbacks to be defined through the SET_PM_RUNTIME_PM_OPS macro, which means these are available for CONFIG_PM.

By using the new runtime PM helper functions especially the two scenarios below will be addressed.

Quoted 6 lines

1) The PM core prevents .runtime_suspend callbacks from being invoked during system suspend. That means even for a runtime PM centric subsystem and driver, the device needs to be put into low power state from a system suspend callback. Otherwise it may very well be left in full power state (runtime resumed) while the system is suspended. By using the new helper functions, we make sure to walk the hierarchy of a device's power domain, subsystem and driver.

I thought it was the case that runtime PM was only disabled during the 'late' phase now. Isn't that enough to allow runtime callbacks in the
normal suspend/resume hooks now? /me looks.

Quoted 7 lines

oh, wait. Ee still have the _get_noresume() in device_prepare(). hmm

Either way, I'm not not a big fan of new functions. Personally, I think subsystems/busses/pm_domains should be able to opt out of the PM core behavior that blocks runtime PM transitions during system suspend. Something like the (untested) hack below. That way, we could avoid the need for new helper functions.

And if one of the subsystems in question is the platform bus type, then adding the flag doesn't really make sense, because that means that on many system it will be set for the majority of devices. :-)

That said I'm tired of this stuff already. If you really really want to remove the bumping up and dropping of the usage counter during system suspend/resume by the core, please feel free to submit a patch for that and I'll apply it. However, if it causes any regressions to happen anywhere, it will be dropped and we'll never talk about this again.

Quoted 5 lines
Quoted 1 line

Deal?

No deal. I prefer the runtime PM helpers, I think that is the right approach. I also believe this is what Alan Stern also would prefer, right!? So let's convince Kevin instead. :-)

I don't need much convincing.

My preference is for fewer functions/helpers because runtime PM is already complicated enough for drivers. However, I'm not going to object to the helpers because they will allow us to simplify many drivers/subsystems that are trying to handle the various combinations of suspend/resume and runtime PM, so it's a step in the right direction.

Kevin