fix clock controller register size on Meson8/Meson8b
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 2 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 2 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] fix clock controller register size on Meson8/Meson8b
Quoted 9 lines · Martin Blumenstingl
While working on some clock controller changes I found that the register size cannot be correct as it overlaps with the reset controller.
Amlogic's GPL kernel sources confirm this, as well as a discussion I had (privately) with Yixun Lan a while ago:Quoted 3 lines
I think
0x460is too big, and we could narrow it down (to a small size) but I haven't looked at the meson8 datasheet for what the exact size of this
Quoted 6 lines
The clock controller itself doesn't have a dedicated size because (just like on GXBB/GXL/GXM) the clock controller is part of a register area called "HHI". On GXBB this is
0x400wide, which matches Meson8/Meson8b/Meson8m2 because the reset controller begins at CBUS +0x4404(0x4400is some kind of version register), so "HHI" starting at0x4000and ending at0x4400sounds reasonable.
Agreed.
Applied to v4.19/dt. Not sure if I'll get another PR out for the v4.19 merge window, but if not, I'll queue with fixes v4.19-rc.
Thanks for the fixes,
Kevin