Enable ECDSA FIT verification for stm32mp
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest5 patches 10 repliesIn review
- v46 patches 0 repliesSuperseded
- v36 patches 0 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 6 patches | 7 replies | Superseded | |
| v1 | 0 of 5 patches | 0 replies | Superseded |
Changes in v5 from the cover letter
- Use U_BOOT_CRYPTO_ALGO() to add ECDSA to .u_boot_list
- No need to #define IMAGE_ENABLE_VERIFY_ECDSA
- Use ut_asserteq(x, -ENODEV) instead of ut_assert(x == -ENODEV)
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | dm: crypto: Define UCLASS API for ECDSA signature verificationinclude/ include/ | +40 | 1 reply | |
| 1/5 | dm: crypto: Define UCLASS API for ECDSA signature verificationinclude/ include/ | +40 | 2 replies | |
| 2/5 | lib: ecdsa: Implement UCLASS_ECDSA verification on targetlib/ lib/ lib/ +2 more | +160 | 1 reply | |
| 2/5 | lib: ecdsa: Implement UCLASS_ECDSA verification on targetlib/ lib/ lib/ +2 more | +160 | 1 reply | |
| 3/5 | arm: stm32mp1: Implement ECDSA signature verificationarch/ arch/ arch/ | +112 | 0 replies | |
| 3/5 | arm: stm32mp1: Implement ECDSA signature verificationarch/ arch/ arch/ | +112 | 2 replies | |
| 4/5 | Kconfig: FIT_SIGNATURE should not select RSA_VERIFYcommon/ | +4 | 1 reply | |
| 4/5 | Kconfig: FIT_SIGNATURE should not select RSA_VERIFYcommon/ | +4 | 2 replies | |
| 5/5 | test: dm: Add test for ECDSA UCLASS supportconfigs/ test/ test/ | +42 | 2 replies | |
| 5/5 | test: dm: Add test for ECDSA UCLASS supportconfigs/ test/ test/ | +41 | 2 replies |
Reviews trailers per patch
All 10 patches have a Reviewed-by or Acked-by.
| Patch | Simon Glass | Igor Opaniuk | Patrick Delaunay |
|---|---|---|---|
| 1/5 | R-b | ||
| 1/5 | R-b | ||
| 2/5 | R-b R-b | R-b | |
| 2/5 | R-b R-b | R-b | |
| 3/5 | R-b | ||
| 3/5 | R-b | ||
| 4/5 | R-b R-b | R-b R-b | R-b |
| 4/5 | R-b R-b | R-b R-b | R-b |
| 5/5 | R-b R-b | R-b | |
| 5/5 | R-b R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v5 0/5] Enable ECDSA FIT verification for stm32mp
This series is based on the following:
"[PATCH 00/18] image: Reduce #ifdef abuse in image code"
This rebase is awesome because we don't need to change #defines in common code or rely on hidden #ifdefs.
Q: Will there be a software-only implementation of ECDSA ?
A: That is the goal, so that we can have more extensive testing with
the sandbox. I don not have the bandwidth to implement it. There has been an initial poer of software ecdsa here:
https://github.com/timr11/u-boot/tree/ecdsa-vrf-1
Q: Can more code be shared with the RSA verification path?
A: Probably yes. Mostly having to do with parsing the "/signature"
node and "key-name-hint"s in the u-boot FDT. Although there isn't any copypasted RSA code, or code with substantial similarity.
Changes since v4:
- Use U_BOOT_CRYPTO_ALGO() to add ECDSA to .u_boot_list
- No need to #define IMAGE_ENABLE_VERIFY_ECDSA
- Use ut_asserteq(x, -ENODEV) instead of ut_assert(x == -ENODEV)
Changes since v3:
- Remove unused ecdsa_check_key() function
Changes since v2:
- Spell out "elliptic curve" in Kconfig (Although RSA isn't spelled out)
Changes since v1:
- Add test to make sure the UCLASS is enabled
- Fix check against wrong sig_len in ecdsa_romapi.c
- s/U_BOOT_DEVICE/U_BOOT_DRVINFO/
- Use "if(!ret)" instead of "if (ret == 0)"
- Use uclass_first_device_err() instead of uclass_first_device()
- Make sure #includes are correctly alphabetized
Alexandru Gagniuc (5):
dm: crypto: Define UCLASS API for ECDSA signature verification
lib: ecdsa: Implement UCLASS_ECDSA verification on target
arm: stm32mp1: Implement ECDSA signature verification
Kconfig: FIT_SIGNATURE should not select RSA_VERIFY
test: dm: Add test for ECDSA UCLASS support
arch/arm/mach-stm32mp/Kconfig | 9 ++ arch/arm/mach-stm32mp/Makefile | 1 + arch/arm/mach-stm32mp/ecdsa_romapi.c | 102 ++++++++++++++++++++ common/Kconfig.boot | 8 +- configs/sandbox_defconfig | 2 + include/crypto/ecdsa-uclass.h | 39 ++++++++ include/dm/uclass-id.h | 1 + lib/Kconfig | 1 + lib/Makefile | 1 + lib/ecdsa/Kconfig | 23 +++++ lib/ecdsa/Makefile | 1 + lib/ecdsa/ecdsa-verify.c | 134 +++++++++++++++++++++++++++ test/dm/Makefile | 1 + test/dm/ecdsa.c | 39 ++++++++ 14 files changed, 358 insertions(+), 4 deletions(-) create mode 100644 arch/arm/mach-stm32mp/ecdsa_romapi.c create mode 100644 include/crypto/ecdsa-uclass.h create mode 100644 lib/ecdsa/Kconfig create mode 100644 lib/ecdsa/Makefile create mode 100644 lib/ecdsa/ecdsa-verify.c create mode 100644 test/dm/ecdsa.c
Signature · 1 line
2.31.1