Skip to content

Don't receive packets when the napi budget == 0

Eric W. Biederman netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16bnx2x: Don't receive packets when the napi budget == 0drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c+2 -00 replies
2/16i40e: Don't receive packets when the napi budget == 0drivers/net/ethernet/intel/i40e/i40e_txrx.c+3 -00 replies
3/16igb: Don't receive packets when the napi budget == 0drivers/net/ethernet/intel/igb/igb_main.c+2 -20 replies
4/16ixgbe: Don't receive packets when the napi budget == 0drivers/net/ethernet/intel/ixgbe/ixgbe_main.c+2 -20 replies
5/16amd8111e: Don't receive packets when the napi budget == 0drivers/net/ethernet/amd/amd8111e.c+3 -00 replies
6/16enic: Don't receive packets when the napi budget == 0drivers/net/ethernet/cisco/enic/enic_main.c+8 -60 replies
7/16fs_enet: Don't receive packets when the napi budget == 0drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c+3 -00 replies
8/16ibmveth: Don't receive packets when the napi budget == 0drivers/net/ethernet/ibm/ibmveth.c+2 -20 replies
9/16sky2: Don't receive packets when the napi budget == 0drivers/net/ethernet/marvell/sky2.c+3 -01 reply
10/16mlx4: Don't receive packets when the napi budget == 0drivers/net/ethernet/mellanox/mlx4/en_rx.c+3 -00 replies
11/16s2io: Don't receive packets when the napi budget == 0drivers/net/ethernet/neterion/s2io.c+3 -00 replies
12/16tilegx: Don't receive packets when the napi budget == 0drivers/net/ethernet/tile/tilegx.c+3 -00 replies
13/16tilepro: Don't receive packets when the napi budget == 0drivers/net/ethernet/tile/tilepro.c+3 -00 replies
14/16tc35815: Don't receive packets when the napi budget == 0drivers/net/ethernet/toshiba/tc35815.c+3 -00 replies
15/16vxge: Don't receive packets when the napi budget == 0drivers/net/ethernet/neterion/vxge/vxge-main.c+4 -00 replies
16/16sfc: Don't receive packets when the napi budget == 0drivers/net/ethernet/sfc/ef10.c drivers/net/ethernet/sfc/farch.c+6 -09 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/16] Don't receive packets when the napi budget == 0

After reading through all 120 drivers supporting netpoll I have found 16 more that process at least received packet when the napi budget == 0.

Processing more packets than your budget has always been a bug but we haven't cared before so it looks like these drivers slipped through, and need fixes.

As netpoll will shortly be using a budget of 0 to get the tx queue processing with the rx queue processing we now care.

Eric W. Biederman (16):

      bnx2x: Don't receive packets when the napi budget == 0
      i40e: Don't receive packets when the napi budget == 0
      igb: Don't receive packets when the napi budget == 0
      ixgbe: Don't receive packets when the napi budget == 0
      amd8111e: Don't receive packets when the napi budget == 0
      enic: Don't receive packets when the napi budget == 0
      fs_enet: Don't receive packets when the napi budget == 0
      ibmveth: Don't receive packets when the napi budget == 0
      sky2: Don't receive packets when the napi budget == 0
      mlx4: Don't receive packets when the napi budget == 0
      s2io: Don't receive packets when the napi budget == 0
      tilegx: Don't receive packets when the napi budget == 0
      tilepro: Don't receive packets when the napi budget == 0
      tc35815: Don't receive packets when the napi budget == 0
      vxge: Don't receive packets when the napi budget == 0
      sfc: Don't receive packets when the napi budget == 0
 drivers/net/ethernet/amd/amd8111e.c                |    3 +++
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c    |    2 ++
 drivers/net/ethernet/cisco/enic/enic_main.c        |   14 ++++++++------
 .../net/ethernet/freescale/fs_enet/fs_enet-main.c  |    3 +++
 drivers/net/ethernet/ibm/ibmveth.c                 |    4 ++--
 drivers/net/ethernet/intel/i40e/i40e_txrx.c        |    3 +++
 drivers/net/ethernet/intel/igb/igb_main.c          |    4 ++--
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c      |    4 ++--
 drivers/net/ethernet/marvell/sky2.c                |    3 +++
 drivers/net/ethernet/mellanox/mlx4/en_rx.c         |    3 +++
 drivers/net/ethernet/neterion/s2io.c               |    3 +++
 drivers/net/ethernet/neterion/vxge/vxge-main.c     |    4 ++++
 drivers/net/ethernet/sfc/ef10.c                    |    3 +++
 drivers/net/ethernet/sfc/farch.c                   |    3 +++
 drivers/net/ethernet/tile/tilegx.c                 |    3 +++
 drivers/net/ethernet/tile/tilepro.c                |    3 +++
 drivers/net/ethernet/toshiba/tc35815.c             |    3 +++
 17 files changed, 53 insertions(+), 12 deletions(-)

Eric