Skip to content

Using dev_kfree_skb_any for functions called in multiple contexts

Eric W. Biederman netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11bonding: Call dev_kfree_skby_any instead of kfree_skb.drivers/net/bonding/bond_3ad.c drivers/net/bonding/bond_alb.c drivers/net/bonding/bond_main.c+9 -9262 replies
2/11bnx2: Call dev_kfree_skby_any instead of dev_kfree_skb.drivers/net/ethernet/broadcom/bnx2.c+5 -53 replies
3/11bnx2x: Call dev_kfree_skby_any instead of dev_kfree_skb.drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c+1 -10 replies
4/11tg3: Call dev_kfree_skby_any instead of dev_kfree_skb.drivers/net/ethernet/broadcom/tg3.c+7 -70 replies
5/11bcm63xx_enet: Call dev_kfree_skby_any instead of dev_kfree_skb.drivers/net/ethernet/broadcom/bcm63xx_enet.c+2 -20 replies
6/11e1000: Call dev_kfree_skby_any instead of dev_kfree_skb.drivers/net/ethernet/intel/e1000/e1000_main.c+9 -90 replies
7/11igbvf: Call dev_kfree_skby_any instead of dev_kfree_skb.drivers/net/ethernet/intel/igbvf/netdev.c+1 -10 replies
8/11ixgb: Call dev_kfree_skby_any instead of dev_kfree_skb.drivers/net/ethernet/intel/ixgb/ixgb_main.c+3 -30 replies
9/11mlx4: Call dev_kfree_skby_any instead of dev_kfree_skb.drivers/net/ethernet/mellanox/mlx4/en_tx.c+1 -10 replies
10/11benet: Call dev_kfree_skby_any instead of kfree_skb.drivers/net/ethernet/emulex/benet/be_main.c+1 -10 replies
11/11gianfar: Carefully free skbs in functions called by netpoll.drivers/net/ethernet/freescale/gianfar.c+3 -30 replies

Reviews trailers per patch

1 of 11 patches has a Reviewed-by or Acked-by.

PatchEric Dumazet
1/11A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH next-next 0/11] Using dev_kfree_skb_any for functions called in multiple contexts

This patchset should be an uncontroversial set of changes to change dev_kfree_skb to dev_kfree_skb_any for code paths that are called in hard irq contexts in addition to other contexts. netpoll is the reason this code gets called in multiple contexts.

There is more coming but these changes are a good starting place, and stand on their own.

Eric W. Biederman (11):
bonding: Call dev_kfree_skby_any instead of kfree_skb.
bnx2: Call dev_kfree_skby_any instead of dev_kfree_skb.
bnx2x: Call dev_kfree_skby_any instead of dev_kfree_skb.
tg3: Call dev_kfree_skby_any instead of dev_kfree_skb.
bcm63xx_enet: Call dev_kfree_skby_any instead of dev_kfree_skb.
e1000: Call dev_kfree_skby_any instead of dev_kfree_skb.
igbvf: Call dev_kfree_skby_any instead of dev_kfree_skb.
ixgb: Call dev_kfree_skby_any instead of dev_kfree_skb.
mlx4: Call dev_kfree_skby_any instead of dev_kfree_skb.
benet: Call dev_kfree_skby_any instead of kfree_skb.
gianfar: Carefully free skbs in functions called by netpoll.

 drivers/net/bonding/bond_3ad.c                  |    2 +-
 drivers/net/bonding/bond_alb.c                  |    2 +-
 drivers/net/bonding/bond_main.c                 |   14 +++++++-------
 drivers/net/ethernet/broadcom/bcm63xx_enet.c    |    4 ++--
 drivers/net/ethernet/broadcom/bnx2.c            |   10 +++++-----
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c |    2 +-
 drivers/net/ethernet/broadcom/tg3.c             |   14 +++++++-------
 drivers/net/ethernet/emulex/benet/be_main.c     |    2 +-
 drivers/net/ethernet/freescale/gianfar.c        |    6 +++---
 drivers/net/ethernet/intel/e1000/e1000_main.c   |   18 +++++++++---------
 drivers/net/ethernet/intel/igbvf/netdev.c       |    2 +-
 drivers/net/ethernet/intel/ixgb/ixgb_main.c     |    6 +++---
 drivers/net/ethernet/mellanox/mlx4/en_tx.c      |    2 +-
 13 files changed, 42 insertions(+), 42 deletions(-)

Eric