Skip to content

Add common cpuidle code for consolidation.

Kevin Hilman linux-arm-kernel 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 4/40 of 7 patches 0 repliesNew
  2. v3 posting 3/40 of 7 patches 0 repliesSuperseded
  3. v3 posting 2/40 of 7 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v3 posting 1/41 of 7 patches0 repliesSuperseded

Patches in v3 posting 4/4 No applies recorded yet

None of the 7 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/7] Add common cpuidle code for consolidation.
Quoted 7 lines · Rob Lee
Quoted 5 lines · Kevin Hilman

I noticed that the generic code uses ktime_get() for measuring time. On OMAP, we use getnstimeofday() because I while back I remember having problems with the interaction of CPUidle state measurements and system suspend. Any idle activity during system suspend/resume ktime_get() will WARN() because the timekeeping system has been suspended.

Quoted 5 lines

It seems that all the time keeping functions including getnstimeofday() now have the "WARN_ON(timekeeping_suspended)" or WARN_ON_ONCE. ?So I'd like to stick with ktime_get unless I'm missing something about the suspend warning or unless there is some other reason why getnstieofday() is preferred.

I agree.

I've convinced myself that my use of getnstimeofday() is because of a problem that doesn't exist anymore in mainline, and now that the timekeeping core has been converted to use syscore_ops, use of ktime_get() is good.

Kevin

Read the cover letter in its thread